Make Vsphere GA: Enabling Vsphere Metrics/Logs by ishleenk17 · Pull Request #3653 · elastic/integrations

ishleenk17 · 2022-07-05T11:22:38Z

Enhancement

What does this PR do?

This PR enables below things in Vsphere:

Receiving metrics/logs in integration
Addition of system tests
Update on dashboards
Update on fields.yml
Support for new metrices

Checklist

I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Bring up the vcsim simulator on system and add integration. It should start the metrics flow to Kibana

Related issues

Closes Make Vsphere GA #3508

elasticmachine · 2022-07-05T11:42:31Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-07-22T06:34:54.737+0000
Duration: 19 min 7 sec

Test stats 🧪

Test	Results
Failed	0
Passed	18
Skipped	0
Total	18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

elasticmachine · 2022-07-05T11:42:44Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`1/1`)	💚
Files	100.0% (`1/1`)	💚 2.941
Classes	100.0% (`1/1`)	💚 2.941
Methods	100.0% (`18/18`)	💚 10.749
Lines	89.796% (`44/49`)	👎 -0.787
Conditionals	100.0% (`0/0`)	💚

muthu-mps · 2022-07-06T07:44:13Z

The documentation could include the vSphere configuration details.

ishleenk17 · 2022-07-06T08:27:50Z

The documentation could include the vSphere configuration details.

Yes, I am looking at what would be the best way to document this part.
As we are using simulator and those details need not be in the README necessarily.
Planning to have another doc in integration stating how we can bring up Vsphere.

ManojS-shetty · 2022-07-06T09:36:13Z

Can we have a single liner definitions for each data stream in README documentation file.?

ishleenk17 · 2022-07-06T10:24:11Z

Can we have a single liner definitions for each data stream in README documentation file.?

good point. Done

…ations into vsphere_ga

ishleenk17 · 2022-07-20T11:08:01Z

/test

jsoriano

This is looking good, added some small comments.

lalit-satapathy · 2022-07-22T05:17:18Z

Capturing offline review feedbacks/status:

Long term post-GA need integration test on a production vspshere installation(future)
Extra field not showing on beats sample event but on integration (future, let's file an beats issue for this)
Can we test the get_custom_fields manually once ( limitation of the simulator. )
Datastores to hosts change need to ensure it is working (done)
What is the secured way to connect to vsphere ( test both true/false insecure in vspehere). (verified by @ishleenk17)
fix readme link (done)
Improve field description (done).

LGTM!

ishleenk17 · 2022-07-22T05:38:50Z

Capturing offline review feedbacks/status:

Long term post-GA need integration test on a production vspshere installation(future)

Extra field not showing on beats sample event but on integration (future, let's file an beats issue for this)

Can we test the get_custom_fields manually once ( limitation of the simulator. )

Datastores to hosts change need to ensure it is working (done)

What is the secured way to connect to vsphere ( test both true/false insecure in vspehere). (verified by @ishleenk17)

fix readme link (done)

Improve field description (done).

LGTM!

Links for the open issue:

Vsphere Production level testing
Test for Custom fields for Virtualmachine
Check for network names presence in the sample event in beats

muthu-mps

LGTM!

* Make Vsphere GA: Basic changes to enable Vsphere * Update the fields * update log expected file * Having the dashboards by value * Resolving formating issue for the dashboards * update dashboards * Replace beta to ga * Addressing review comments * Updating the README * Update README * Adding support for new metrices * Format sample event * Update README * Update ingest pipeline * Update metric type * Update vdashboard by value * Update dashboard, add new panels * Update README * Update README * Update Dashboards * Add network_names to dashboard * Update field descriptions and README * Updated formated fields.yml * Addressing review comments * Update fields.yml and README * Update the dockerfile and sample event , README * Update fields.yml

ishleenk17 added 2 commits July 5, 2022 16:47

Make Vsphere GA: Basic changes to enable Vsphere

5c85b4a

Update the fields

501484f

ishleenk17 added 4 commits July 5, 2022 18:03

update log expected file

9ce40f4

Having the dashboards by value

c56a57a

Resolving formating issue for the dashboards

197cab1

update dashboards

13a7eef

ishleenk17 marked this pull request as ready for review July 6, 2022 07:13

ishleenk17 requested a review from a team as a code owner July 6, 2022 07:13

ishleenk17 changed the title ~~Make Vsphere GA: Basic changes to enable Vsphere~~ Jul 6, 2022

ManojS-shetty self-requested a review July 6, 2022 07:20

Replace beta to ga

91842a7

muthu-mps reviewed Jul 6, 2022

View reviewed changes

Comment thread packages/vsphere/data_stream/log/sample_event.json Outdated

muthu-mps self-requested a review July 6, 2022 07:44

muthu-mps reviewed Jul 6, 2022

View reviewed changes

Comment thread packages/vsphere/data_stream/datastore/fields/fields.yml

Comment thread packages/vsphere/changelog.yml Outdated

Addressing review comments

7a2dca5

Updating the README

26f5497

ishleenk17 added 6 commits July 6, 2022 16:46

Update README

a6499c6

Adding support for new metrices

eb4f45a

Merge branch 'vsphere_ga' of https://github.com/ishleenk17/ish_integr…

16c7335

…ations into vsphere_ga

Format sample event

782292b

Update README

79c60ca

Update ingest pipeline

0666746

ishleenk17 mentioned this pull request Jul 12, 2022

vSphere module - Percentage for CPU & Mem elastic/beats#24401

Closed

ManojS-shetty reviewed Jul 13, 2022

View reviewed changes

ishleenk17 added 8 commits July 13, 2022 11:53

Update metric type

57c0528

Update vdashboard by value

d7870f3

Update dashboard, add new panels

751ebe9

Update README

0d0f2e6

Update README

1b82cf7

Update Dashboards

174d08f

Add network_names to dashboard

056d524

Update field descriptions and README

263d365

ishleenk17 and others added 2 commits July 21, 2022 11:53

Merge branch 'main' into vsphere_ga

9abbae9

Updated formated fields.yml

069d1ba

ishleenk17 requested a review from jsoriano July 21, 2022 08:08

jsoriano reviewed Jul 21, 2022

View reviewed changes

ishleenk17 added 3 commits July 21, 2022 15:16

Addressing review comments

d0c86bc

Update fields.yml and README

314a577

Update the dockerfile and sample event , README

2659229

jsoriano approved these changes Jul 21, 2022

View reviewed changes

Comment thread packages/vsphere/_dev/deploy/docker/docker-compose.yml

muthu-mps reviewed Jul 22, 2022

View reviewed changes

Comment thread packages/vsphere/data_stream/host/fields/fields.yml Outdated

Comment thread packages/vsphere/data_stream/host/fields/fields.yml Outdated

Comment thread packages/vsphere/data_stream/virtualmachine/fields/fields.yml Outdated

Update fields.yml

3e7f193

muthu-mps self-requested a review July 22, 2022 07:32

muthu-mps approved these changes Jul 22, 2022

View reviewed changes

ishleenk17 merged commit 16553dc into elastic:main Jul 22, 2022

ishleenk17 deleted the vsphere_ga branch July 22, 2022 07:35

Uh oh!

Conversation

ishleenk17 commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Checklist

How to test this PR locally

Related issues

elasticmachine commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

elasticmachine commented Jul 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

Uh oh!

muthu-mps commented Jul 6, 2022

Uh oh!

Uh oh!

ishleenk17 commented Jul 6, 2022

ManojS-shetty commented Jul 6, 2022

ishleenk17 commented Jul 6, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ishleenk17 commented Jul 20, 2022

jsoriano left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lalit-satapathy commented Jul 22, 2022

ishleenk17 commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

muthu-mps left a comment

Choose a reason for hiding this comment

Labels

6 participants

ishleenk17 commented Jul 5, 2022 •

edited

Loading

elasticmachine commented Jul 5, 2022 •

edited

Loading

elasticmachine commented Jul 5, 2022 •

edited

Loading

ishleenk17 commented Jul 22, 2022 •

edited

Loading