Skip to content

[httpjson] Remove defaults from manifest. - #3661

Merged
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:remove-httpjson-defaults
Jul 7, 2022
Merged

[httpjson] Remove defaults from manifest.#3661
marc-gr merged 2 commits into
elastic:mainfrom
marc-gr:remove-httpjson-defaults

Conversation

@marc-gr

@marc-gr marc-gr commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Template breaks when yaml contents are all comments under some circumstances. The default examples were causing some issues because of that for some configurations.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:httpjson Custom API labels Jul 7, 2022
@marc-gr
marc-gr requested a review from P1llus July 7, 2022 08:55
@marc-gr
marc-gr requested a review from a team as a code owner July 7, 2022 08:55
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jul 7, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-07T08:57:09.395+0000

  • Duration: 17 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.171
Classes 100.0% (0/0) 💚 3.171
Methods 100.0% (3/3) 💚 10.445
Lines 100.0% (0/0) 💚 8.916
Conditionals 100.0% (0/0) 💚
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:httpjson Custom API

3 participants