Skip to content

[cisco_duo] Fix bad value in ip and date fields - #3700

Merged
andrewkroh merged 3 commits into
elastic:mainfrom
vinit-chauhan:cisco_duo_pipeline_fix
Jul 26, 2022
Merged

[cisco_duo] Fix bad value in ip and date fields#3700
andrewkroh merged 3 commits into
elastic:mainfrom
vinit-chauhan:cisco_duo_pipeline_fix

Conversation

@vinit-chauhan

@vinit-chauhan vinit-chauhan commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

This PR adds support for handling bad values in ip and date fields.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Related issues

Screenshots

image
image
image
image
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner July 13, 2022 13:28
@elasticmachine

elasticmachine commented Jul 13, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-14T14:58:20.455+0000

  • Duration: 22 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 3.049
Classes 100.0% (5/5) 💚 3.049
Methods 100.0% (50/50) 💚 10.792
Lines 93.253% (622/667) 👍 3.048
Conditionals 100.0% (0/0) 💚
andrewkroh
andrewkroh reviewed Jul 13, 2022
View reviewed changes
Comment thread packages/cisco_duo/data_stream/admin/elasticsearch/ingest_pipeline/default.yml
formats:
- UNIX
on_failure:
- append:

@andrewkroh andrewkroh Jul 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the pipeline appends to error.message then the global on_failure should also be appending so that no messages are lost. Currently it uses set so it will overwrite this error.

@vinit-chauhan vinit-chauhan Jul 14, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, I missed it. I'll update it.
@andrewkroh

andrewkroh commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

@vinit-elastic Is there test case with an IP field containing "None" already in the package?
@vinit-chauhan

vinit-chauhan commented Jul 15, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@vinit-elastic Is there test case with an IP field containing "None" already in the package?

Hey @andrewkroh,
The reason we didn't add the log is that adding the log in the pipeline test would make the test fail with the following error.
unexpected pipeline error (unexpected error.message type []interface {}): ['None' is not an IP string literal.]
@andrewkroh

andrewkroh commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Ok, thanks. So in order to support this type of testing we need a way to ignore the error.message from the test config.
@vinit-chauhan vinit-chauhan self-assigned this Jul 20, 2022
@andrewkroh

andrewkroh commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

Related: elastic/elastic-package#912
@andrewkroh
andrewkroh merged commit 0a2a221 into elastic:main Jul 26, 2022
@andrewkroh andrewkroh mentioned this pull request Jul 27, 2022
Merged
@zmoog zmoog mentioned this pull request Aug 21, 2023
Merged
1 task
@vinit-chauhan
vinit-chauhan deleted the cisco_duo_pipeline_fix branch April 1, 2026 23:57
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@vinit-chauhan
[cisco_duo] Fix bad value in ip and date fields (elastic#3700)
42ba4bf 
* Handle bad values in IP and Date fields

* Updated the changelog file

* Updated set to append processor in on_failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_duo Cisco Duo

3 participants

@vinit-chauhan @elasticmachine @andrewkroh