Skip to content

[keycloak] Correct spelling "UCT -> UTC" - #3708

Merged
andrewkroh merged 3 commits into
elastic:mainfrom
fionera:patch-1
Jul 21, 2022
Merged

[keycloak] Correct spelling "UCT -> UTC"#3708
andrewkroh merged 3 commits into
elastic:mainfrom
fionera:patch-1

Conversation

@fionera

@fionera fionera commented Jul 14, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix typo in 'Timezone Offset' description.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@fionera
fionera requested a review from a team as a code owner July 14, 2022 10:00
@cla-checker-service

cla-checker-service Bot commented Jul 14, 2022

Copy link
Copy Markdown

💚 CLA has been signed

@fionera fionera changed the title fix(keycloak): Correct spelling "UCT -> UTC" Jul 14, 2022
@elasticmachine

elasticmachine commented Jul 14, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T23:41:26.906+0000

  • Duration: 19 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@adriansr

Copy link
Copy Markdown
Contributor

Thanks for your contribution @fionera !

You'll have to sign the CLA before we can review.

I see we've made this mistake in a few places:

packages/hid_bravura_monitor/data_stream/log/manifest.yml
packages/keycloak/data_stream/log/manifest.yml
packages/microsoft_dhcp/data_stream/log/manifest.yml
packages/pfsense/data_stream/log/manifest.yml
packages/qnap_nas/data_stream/log/manifest.yml
packages/snort/data_stream/log/manifest.yml
@legoguy1000

Copy link
Copy Markdown
Contributor

Thanks for your contribution @fionera !

You'll have to sign the CLA before we can review.

I see we've made this mistake in a few places:

packages/hid_bravura_monitor/data_stream/log/manifest.yml
packages/keycloak/data_stream/log/manifest.yml
packages/microsoft_dhcp/data_stream/log/manifest.yml
packages/pfsense/data_stream/log/manifest.yml
packages/qnap_nas/data_stream/log/manifest.yml
packages/snort/data_stream/log/manifest.yml

Thats awkward. I created 4 of those. I must have done it on one and then as I created/copied the others it propogated.

@adriansr

Copy link
Copy Markdown
Contributor

Thats awkward. I created 4 of those. I must have done it on one and then as I created/copied the others it propogated.

That's to be expected when one creates so many useful integrations.

@andrewkroh andrewkroh changed the title Bug: fix(keycloak): Correct spelling "UCT -> UTC" Jul 20, 2022
@andrewkroh

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 95.0% (19/20)
Lines 91.12% (236/259)
Conditionals 100.0% (0/0) 💚
@andrewkroh
andrewkroh merged commit 26a3bd1 into elastic:main Jul 21, 2022
@fionera
fionera deleted the patch-1 branch August 19, 2022 03:03
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Fix typo in 'Timezone Offset' description ("UCT -> UTC").

Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:keycloak Keycloak

6 participants