Skip to content

cisco_asa: add handling of AAA operations - #3740

Merged
efd6 merged 3 commits into
elastic:mainfrom
efd6:b32257-cisco_asa
Aug 2, 2022
Merged

cisco_asa: add handling of AAA operations#3740
efd6 merged 3 commits into
elastic:mainfrom
efd6:b32257-cisco_asa

Conversation

@efd6

@efd6 efd6 commented Jul 19, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This adds handling of authentication fields for Cisco ASA AAA message types.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Jul 19, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-02T22:36:18.019+0000

  • Duration: 19 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 19, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.868
Classes 100.0% (1/1) 💚 2.868
Methods 94.444% (17/18) 👍 5.2
Lines 65.161% (1197/1837) 👎 -25.438
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review July 19, 2022 06:47
@efd6
efd6 requested a review from a team as a code owner July 19, 2022 06:47
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 force-pushed the b32257-cisco_asa branch 2 times, most recently from eabc150 to b7f5320 Compare July 19, 2022 11:37
@leweafan

Copy link
Copy Markdown

@efd6 seems like even.outcome always "success" but for failed authentications it should be "failure".

@efd6

efd6 commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

@leweafan Yeah, this can be confusing. Success is always a contextual thing; from the perspective of the attempting authenticator, a failure to auth is a failure, but if this entity is malicious it is a success for the people who matter. So in the ECS definition you can see

event.outcome simply denotes whether the event represents a success or a failure from the perspective of the entity that produced the event.

The entity that produced the event is the device and it must have confidence in its decisions, so all authentications that have a definitive answer are successful. If there were a failure due to a network or identity store problem, those would be failures.

You can use event.type and event.action to determine whether the login was successful.

It looks like there is some confusion/ambiguity around this. I am looking into it further.

@leweafan

leweafan commented Jul 20, 2022

Copy link
Copy Markdown

@efd6 event.outcome is very important for SIEM cause if we go to Sercurity -> Hosts -> Authentications there is a graph for successful and failed attempts and a table representation with users their 'Successes'/'Failures'/'Last failure'/'Last failed source'/'Last failed destination' that depend on event.outcome = "failure". Please find screenshots in attachments.
Also according to ECS documentation https://www.elastic.co/guide/en/security/current/siem-field-reference.html
Screenshot 2022-07-20 at 12 08 05

Screenshot 2022-07-20 at 12 00 11
Screenshot 2022-07-20 at 11 57 10

@efd6

efd6 commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

Yes, having had a look at the background discussion, this appears to be the original intention. I will make this change.

@efd6

efd6 commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

@leweafan Please also take a look at #3750.

@leweafan

leweafan commented Jul 20, 2022

Copy link
Copy Markdown

@efd6 answered a minute before to andrewkroh about checkpoint version in another issue elastic/beats#32230

@efd6

efd6 commented Jul 20, 2022

Copy link
Copy Markdown
Contributor Author

@leweafan Thanks for that, I was also thinking you might like to confirm the orientation of success/failure in that PR.

@leweafan

Copy link
Copy Markdown

@efd6 looks good

@efd6
efd6 force-pushed the b32257-cisco_asa branch from ddeb4ce to 87f9890 Compare July 21, 2022 03:20
@efd6

efd6 commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

/test

@efd6
efd6 force-pushed the b32257-cisco_asa branch from 87f9890 to c32a738 Compare August 2, 2022 21:48
@efd6
efd6 deleted the b32257-cisco_asa branch February 5, 2025 22:07
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_asa Cisco ASA

4 participants