Skip to content

Improve tcp, ssl config descriptions and examples - #3763

Merged
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:3761-tls-desc
Jul 20, 2022
Merged

Improve tcp, ssl config descriptions and examples#3763
taylor-swanson merged 3 commits into
elastic:mainfrom
taylor-swanson:3761-tls-desc

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add link to SSL and TCP configuration doc page in config descriptions
  • Change SSL default example to a server example

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • [ ] I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screen Shot 2022-07-19 at 11 54 07 AM
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-External Integrations Integration:sophos Sophos Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] Integration:juniper_srx Juniper SRX Integration:checkpoint Check Point Integration:cisco_ios Cisco IOS Integration:cisco_ftd Cisco FTD Integration:cisco_asa Cisco ASA Integration:cisco_secure_email_gateway Cisco Secure Email Gateway labels Jul 19, 2022
@taylor-swanson taylor-swanson self-assigned this Jul 19, 2022
@elasticmachine

elasticmachine commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-20T13:32:35.545+0000

  • Duration: 27 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 282
Skipped 0
Total 282

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 19, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 98.095% (103/105) ❕
Classes 98.095% (103/105) ❕
Methods 97.649% (540/553) ❕
Lines 84.783% (13773/16245) ❕
Conditionals 100.0% (0/0) 💚
@taylor-swanson
taylor-swanson marked this pull request as ready for review July 19, 2022 19:47
@taylor-swanson
taylor-swanson requested a review from a team as a code owner July 19, 2022 19:47
@elasticmachine

elasticmachine commented Jul 19, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@taylor-swanson
taylor-swanson merged commit f9622b6 into elastic:main Jul 20, 2022
@taylor-swanson
taylor-swanson deleted the 3761-tls-desc branch July 20, 2022 14:04
This was referenced Jul 26, 2022
Merged
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@taylor-swanson
Improve tcp, ssl config descriptions and examples (elastic#3763)
5484e56 
- Improve tcp, ssl config descriptions and examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point Integration:cisco_asa Cisco ASA Integration:cisco_ftd Cisco FTD Integration:cisco_ios Cisco IOS Integration:cisco_secure_email_gateway Cisco Secure Email Gateway Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] Integration:juniper_srx Juniper SRX Integration:sophos Sophos

3 participants

@taylor-swanson @elasticmachine @efd6