Skip to content

[GCP] Add PubSub data stream - #3788

Merged
endorama merged 7 commits into
mainfrom
unknown repository
Sep 14, 2022
Merged

[GCP] Add PubSub data stream#3788
endorama merged 7 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 21, 2022

Copy link
Copy Markdown

What does this PR do?

Adds pubsub data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Jul 21, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-13T14:33:16.857+0000

  • Duration: 18 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 21, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.703
Classes 100.0% (5/5) 💚 2.703
Methods 90.816% (89/98) 👍 1.101
Lines 95.752% (1375/1436) 👍 4.363
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review July 27, 2022 14:39
@ghost
ghost requested review from a team as code owners July 27, 2022 14:39
@endorama endorama added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 1, 2022
Comment thread packages/gcp/_dev/build/docs/pubsub.md Outdated

The `pubsub` dataset fetches metrics from [PubSub](https://cloud.google.com/pubsub/) in Google Cloud Platform. It contains all metrics exported from the [GCP PubSub Monitoring API](https://cloud.google.com/monitoring/api/metrics_gcp#gcp-pubsub).

You can specify a single region to fetch metrics like `us-central1`. Be aware that GCP Storage does not use zones so `us-central1-a` will return nothing. If no region is specified, it will return metrics from all buckets.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the GCP Storage reference needed here?

Comment thread packages/gcp/changelog.yml Outdated
- description: Remove fields duplicated in ECS fields
type: enhancement
link: https://github.com/elastic/integrations/pull/3609
- description: Add GCP PubSub Data stream

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs update too, maybe after we merge #3159

@ghost

ghost commented Sep 12, 2022

Copy link
Copy Markdown
Author

/test

@endorama
endorama merged commit 0b556f9 into elastic:main Sep 14, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants