Skip to content

checkpoint: fix handling of R81 fields - #3800

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:b32380-checkpoint
Jul 26, 2022
Merged

checkpoint: fix handling of R81 fields#3800
efd6 merged 1 commit into
elastic:mainfrom
efd6:b32380-checkpoint

Conversation

@efd6

@efd6 efd6 commented Jul 22, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes handling of numeric and duplicated fields and removes undocumented fields that appear to be new in R81.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:checkpoint Check Point labels Jul 22, 2022
@efd6 efd6 self-assigned this Jul 22, 2022
@efd6
efd6 force-pushed the b32380-checkpoint branch from c3aaa60 to 32ab46d Compare July 22, 2022 02:25
@efd6
efd6 marked this pull request as ready for review July 22, 2022 02:26
@efd6
efd6 requested a review from a team as a code owner July 22, 2022 02:26
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

elasticmachine commented Jul 22, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T02:26:20.190+0000

  • Duration: 19 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.947
Classes 100.0% (1/1) 💚 2.947
Methods 100.0% (15/15) 💚 10.764
Lines 83.333% (685/822) 👎 -7.242
Conditionals 100.0% (0/0) 💚

@r00tu53r r00tu53r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +474 to 480
- convert:
field: checkpoint.bytes
type: long
ignore_missing: true
- rename:
field: checkpoint.bytes
target_field: network.bytes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of doing this in a single step -

Suggested change
- convert:
field: checkpoint.bytes
type: long
ignore_missing: true
- rename:
field: checkpoint.bytes
target_field: network.bytes
- convert:
field: checkpoint.bytes
target_field: network.bytes
type: long
ignore_missing: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That leaves the value in checkpoint.bytes.

Comment on lines +515 to 521
- convert:
field: checkpoint.packets
type: long
ignore_missing: true
- rename:
field: checkpoint.packets
target_field: network.packets

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking of doing this in a single step -

Suggested change
- convert:
field: checkpoint.packets
type: long
ignore_missing: true
- rename:
field: checkpoint.packets
target_field: network.packets
- convert:
field: checkpoint.packets
type: long
target_field: network.packets
ignore_missing: true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as above

@efd6
efd6 merged commit 6c2e1e0 into elastic:main Jul 26, 2022
@efd6
efd6 deleted the b32380-checkpoint branch February 5, 2025 22:07
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:checkpoint Check Point

3 participants