Skip to content

[panw] Preserve original event for syslog messages - #3811

Merged
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:3774-panw-orig-event
Jul 25, 2022
Merged

[panw] Preserve original event for syslog messages#3811
taylor-swanson merged 2 commits into
elastic:mainfrom
taylor-swanson:3774-panw-orig-event

Conversation

@taylor-swanson

@taylor-swanson taylor-swanson commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Add processor to preserve original event message when using tcp/udp
    with syslog in agent config

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/panw && elastic-package test

Related issues
@taylor-swanson
[panw] Preserve original event for syslog messages
5afcecd 
- Add processor to preserve original event message when using tcp/udp
with syslog in agent config
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Jul 22, 2022
@taylor-swanson taylor-swanson self-assigned this Jul 22, 2022
@elasticmachine

elasticmachine commented Jul 22, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T18:33:23.164+0000

  • Duration: 21 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 22, 2022

Copy link
Copy Markdown

���� Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚 2.941
Classes 100.0% (15/15) 💚 2.941
Methods 98.529% (67/68) 👍 8.798
Lines 94.93% (3183/3353) 👍 4.347
Conditionals 100.0% (0/0) 💚
@taylor-swanson
taylor-swanson marked this pull request as ready for review July 22, 2022 18:54
@taylor-swanson
taylor-swanson requested a review from a team as a code owner July 22, 2022 18:54
@elasticmachine

elasticmachine commented Jul 22, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
efd6
efd6 approved these changes Jul 24, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behaviour here is subtle enough to warrant including the reason for it in the commit message. The explanation in the issue does a good job of it, so it could be copied in at squash.
@taylor-swanson
taylor-swanson merged commit 9733bff into elastic:main Jul 25, 2022
@taylor-swanson
taylor-swanson deleted the 3774-panw-orig-event branch July 25, 2022 12:57
@andrewkroh andrewkroh mentioned this pull request Jul 26, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@taylor-swanson
[panw] Preserve original event for syslog messages (elastic#3811)
2fbd601 
- Add processor to preserve original event message when using tcp/udp
with syslog in agent config, as the syslog processor will replace the original
message after processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:panw Palo Alto Next-Gen Firewall

3 participants

@taylor-swanson @elasticmachine @efd6