Skip to content

all: fix url formatting in config docs - #3881

Merged
efd6 merged 26 commits into
elastic:mainfrom
efd6:3879-cisco_umbrella
Jul 29, 2022
Merged

all: fix url formatting in config docs#3881
efd6 merged 26 commits into
elastic:mainfrom
efd6:3879-cisco_umbrella

Conversation

@efd6

@efd6 efd6 commented Jul 28, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes rendering of the proxy config docs. See screen shot below.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screen Shot 2022-07-28 at 19 06 01
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:cisco_umbrella Cisco Umbrella labels Jul 28, 2022
@efd6 efd6 self-assigned this Jul 28, 2022
@efd6
efd6 force-pushed the 3879-cisco_umbrella branch from 61742c2 to 294b337 Compare July 28, 2022 09:40
@efd6
efd6 marked this pull request as ready for review July 28, 2022 09:40
@efd6
efd6 requested a review from a team as a code owner July 28, 2022 09:40
@elasticmachine

elasticmachine commented Jul 28, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Jul 28, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-29T05:39:21.489+0000

  • Duration: 43 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 918
Skipped 0
Total 918

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Jul 28, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) 💚
Files 98.611% (71/72) 👍 1.57
Classes 98.611% (71/72) 👍 1.57
Methods 94.469% (854/904) 👍 4.825
Lines 94.158% (17486/18571) 👍 2.71
Conditionals 100.0% (0/0) 💚
legoguy1000
legoguy1000 reviewed Jul 28, 2022
View reviewed changes
Comment thread packages/cisco_umbrella/data_stream/log/manifest.yml Outdated

@legoguy1000 legoguy1000 Jul 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only this integration that's affected?? I copied and pasted this from another integration so if is rendering as a link here, I suspect all the other integrations with the proxy config is affected.

@efd6 efd6 Jul 28, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others are affected as well. I'll add them to this PR.
@efd6
efd6 force-pushed the 3879-cisco_umbrella branch from 294b337 to d16e6a5 Compare July 29, 2022 00:17
@efd6
efd6 requested review from a team as code owners July 29, 2022 00:17
@efd6 efd6 changed the title cisco_umbrella: fix url formatting in config docs Jul 29, 2022
@efd6
efd6 force-pushed the 3879-cisco_umbrella branch from d16e6a5 to c4d7183 Compare July 29, 2022 00:20
@efd6

efd6 commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

I have made these changes to obs-cloud-montoring and obs-service-integrations as well since I was here. I hope your toes are OK.
kcreddy
kcreddy reviewed Jul 29, 2022
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update aws_logs package too? Rest LGTM
efd6 added 14 commits July 29, 2022 15:07
@efd6
efd6 force-pushed the 3879-cisco_umbrella branch from c4d7183 to 9222856 Compare July 29, 2022 05:39
@efd6

efd6 commented Jul 29, 2022

Copy link
Copy Markdown
Contributor Author

Not at all sure why I missed that one. Done
@lalit-satapathy
lalit-satapathy requested a review from ritalwar July 29, 2022 07:14
kcreddy
kcreddy approved these changes Jul 29, 2022
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
zmoog
zmoog approved these changes Jul 29, 2022
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ritalwar
ritalwar approved these changes Jul 29, 2022
View reviewed changes

@ritalwar ritalwar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6
efd6 merged commit 5b04640 into elastic:main Jul 29, 2022
This was referenced Aug 15, 2022
Merged
Closed
Merged
@adoadnan adoadnan mentioned this pull request Jan 26, 2023
Closed
@efd6
efd6 deleted the 3879-cisco_umbrella branch February 5, 2025 22:07
@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
all: fix url formatting in config docs (elastic#3881)
5eff4ef 
* 1password
* akamai
* atlassian_bitbucket
* atlassian_confluence
* atlassian_jira
* aws
* aws_logs
* carbon_black_cloud
* cisco_umbrella
* cloudflare
* crowdstrike
* github
* m365_defender
* microsoft_defender_endpoint
* nagios_xi
* okta
* proofpoint
* sentinel_one
* snyk
* tenable_sc
* ti_abusech
* ti_anomali
* ti_cybersixgill
* ti_misp
* ti_otx
* ti_threatq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:cisco_umbrella Cisco Umbrella

7 participants

@efd6 @elasticmachine @zmoog @kcreddy @legoguy1000 @ritalwar @andrewkroh