Skip to content

[Spring Boot] Update the field in audit_events data stream dashboard - #3960

Merged
yug-rajani merged 4 commits into
elastic:mainfrom
harnish-crest:package_spring_boot_update
Aug 30, 2022
Merged

[Spring Boot] Update the field in audit_events data stream dashboard#3960
yug-rajani merged 4 commits into
elastic:mainfrom
harnish-crest:package_spring_boot_update

Conversation

@harnish-crest

@harnish-crest harnish-crest commented Aug 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Bug

What does this PR do?

This PR is of the Spring Boot integration to update the field name in audit_events data stream dashboard and some nits in fields descriptions. Along with the fixes, it also enhances the integration by following some of the best practices of integration development.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/spring_boot directory.
  • Run the following command to run tests.

elastic-package test
@harnish-crest
harnish-crest requested a review from a team as a code owner August 5, 2022 07:11
@elasticmachine

elasticmachine commented Aug 5, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-05T10:22:09.720+0000

  • Duration: 19 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 36
Skipped 0
Total 36

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@yug-rajani yug-rajani added bug Something isn't working, use only for issues Integration:spring_boot Spring Boot Team:Service-Integrations Label for the Observability Service Integrations team labels Aug 5, 2022
@yug-rajani

yug-rajani commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Aug 5, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.953
Classes 100.0% (2/2) 💚 2.953
Methods 100.0% (27/27) 💚 10.458
Lines 93.289% (139/149) 👍 1.808
Conditionals 100.0% (0/0) 💚
@yug-rajani

yug-rajani commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

/test
1 similar comment
@yug-rajani

yug-rajani commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

/test
kush-elastic
kush-elastic approved these changes Aug 5, 2022
View reviewed changes

@kush-elastic kush-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@harnish-crest harnish-crest changed the title [Spring Boot] Update as per best practices Aug 5, 2022
@harnish-crest
harnish-crest marked this pull request as draft August 8, 2022 05:53
@harnish-crest
harnish-crest marked this pull request as ready for review August 9, 2022 11:21
@harnish-crest
harnish-crest requested review from ishleenk17 and removed request for lalit-satapathy August 30, 2022 07:19
@yug-rajani
yug-rajani merged commit 413065d into elastic:main Aug 30, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@harnish-crest
[Spring Boot] Update the field in audit_events data stream dashboard (
3197313 
elastic#3960)

* update spring_boot as per best practices

* update changelog.yml

* update changelog.yml

* update default.yml for system test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:spring_boot Spring Boot Team:Service-Integrations Label for the Observability Service Integrations team

5 participants

@harnish-crest @elasticmachine @yug-rajani @kush-elastic @ishleenk17