Skip to content

Removing EKS resource type rules - #3973

Merged
ofiriro3 merged 3 commits into
elastic:mainfrom
ofiriro3:remove-eks-cluster-related-templates
Aug 9, 2022
Merged

Removing EKS resource type rules#3973
ofiriro3 merged 3 commits into
elastic:mainfrom
ofiriro3:remove-eks-cluster-related-templates

Conversation

@ofiriro3

@ofiriro3 ofiriro3 commented Aug 9, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR removes some of the EKS benchmark rules that are related to cluster auto-detection which we haven't implemented yet.

Explain here the changes you made on the PR.

I removed some of the EKS benchmark template rules.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@ofiriro3 ofiriro3 added the bug Something isn't working, use only for issues label Aug 9, 2022
@ofiriro3
ofiriro3 requested a review from a team as a code owner August 9, 2022 09:40
@ofiriro3 ofiriro3 self-assigned this Aug 9, 2022
@ofiriro3
ofiriro3 requested a review from amirbenun August 9, 2022 09:42
@ofiriro3

ofiriro3 commented Aug 9, 2022

Copy link
Copy Markdown
Contributor Author

Rules that are using EKS resource type - >

image
ofiriro3
ofiriro3 commented Aug 9, 2022
View reviewed changes

@ofiriro3 ofiriro3 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for review
@ofiriro3 ofiriro3 changed the title Removing EKS auto-detect cluster Aug 9, 2022
@elasticmachine

elasticmachine commented Aug 9, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-09T10:33:13.140+0000

  • Duration: 14 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
eyalkraft
eyalkraft reviewed Aug 9, 2022
View reviewed changes
Comment thread packages/cloud_security_posture/changelog.yml Outdated
# newer versions go on top
- version: "0.0.25"
changes:
- description: Remove unimplemented EKS rules from template

@eyalkraft eyalkraft Aug 9, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad indentation
@elasticmachine

elasticmachine commented Aug 9, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.953
Classes 100.0% (0/0) 💚 2.953
Methods 25.0% (1/4) 👎 -64.597
Lines 100.0% (0/0) 💚 8.518
Conditionals 100.0% (0/0) 💚
@ofiriro3
ofiriro3 requested review from eyalkraft and removed request for amirbenun August 9, 2022 10:49
@ofiriro3
ofiriro3 merged commit 015e88d into elastic:main Aug 9, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ofiriro3
Removing EKS resource type rules (elastic#3973)
431c852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

4 participants

@ofiriro3 @elasticmachine @eyalkraft @kfirpeled