Skip to content

Update CSP mapping fields - #4016

Merged
olegsu merged 1 commit into
elastic:mainfrom
olegsu:csp-findings-mapping
Sep 13, 2022
Merged

Update CSP mapping fields#4016
olegsu merged 1 commit into
elastic:mainfrom
olegsu:csp-findings-mapping

Conversation

@olegsu

@olegsu olegsu commented Aug 17, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Update the mapping CSP uses based on elastic/cloudbeat#346

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@olegsu olegsu added enhancement New feature or request deprecation labels Aug 17, 2022
@olegsu
olegsu requested a review from a team as a code owner August 17, 2022 12:14
@elasticmachine

elasticmachine commented Aug 17, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-12T10:29:36.982+0000

  • Duration: 14 min 19 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@eyalkraft

Copy link
Copy Markdown
Contributor

Note that the change log and the manifest must be updated as well
see for example 015e88d

@andrewkroh andrewkroh added the Integration:cloud_security_posture Security Posture Management label Aug 17, 2022
@olegsu
olegsu force-pushed the csp-findings-mapping branch 2 times, most recently from 8c1ebc6 to 5e238fd Compare August 17, 2022 15:39
@elasticmachine

elasticmachine commented Aug 17, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please place these fields' definition in ecs.yml
Also, consider adding the actual type they have, otherwise it uses the default which is keyword.

for example: event.created is of type date

@olegsu
olegsu force-pushed the csp-findings-mapping branch 2 times, most recently from 1a77c4c to 672d76d Compare August 30, 2022 10:44
@olegsu
olegsu requested a review from kfirpeled September 5, 2022 07:44
@olegsu
olegsu force-pushed the csp-findings-mapping branch 5 times, most recently from e001f0b to b49a6e4 Compare September 12, 2022 10:00
@olegsu
olegsu requested a review from a team as a code owner September 12, 2022 10:00
@olegsu
olegsu force-pushed the csp-findings-mapping branch from b49a6e4 to 26f15d1 Compare September 12, 2022 10:01
@olegsu
olegsu force-pushed the csp-findings-mapping branch from 26f15d1 to 63e63e2 Compare September 12, 2022 10:01
@olegsu

olegsu commented Sep 12, 2022

Copy link
Copy Markdown
Contributor Author

/test

@olegsu
olegsu merged commit a5d0772 into elastic:main Sep 13, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Co-authored-by: Marcin Tojek <mtojek@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecation enhancement New feature or request Integration:cloud_security_posture Security Posture Management Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

6 participants