Add unit and metric_type meta to system fields.yml - #402
Conversation
This change updates `fields.yml` defintions to include units and metric type information.
|
Pinging @elastic/integrations (Team:Integrations) |
|
Nice! Already lots of place where this is used. |
fearful-symmetry
left a comment
There was a problem hiding this comment.
Super happy to see us finally adding this.
| type: long | ||
| metric_type: gauge |
There was a problem hiding this comment.
I think this should be actually a keyword 🙂
I don't think we need to handle it as a metric in any case.
| format: percent | ||
| unit: percent |
There was a problem hiding this comment.
unit and format seem a bit redundant most of the times, maybe one can be derived from the other. Or maybe we could add additional checks, e.g. you probably always want to format as percent a metric with percent unit, same with bytes.
There was a problem hiding this comment.
This sounds reasonable, I would prefer to keep them separated for now, as they end up in different places (template vs index pattern), I agree we could do better at linting.
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
|
Thanks for the reviews! @jsoriano this is ready for another go 😇 |
What does this PR do?
This change updates
fields.ymldefintions to include units and metrictype information
Checklist
How to test this PR locally
Once elastic/kibana#82273 is in, system package templates should include
unitandmetric_type_meta fields.Related issues