Skip to content

[GCP] Add GKE data stream - #4098

Merged
4 commits merged into
mainfrom
unknown repository
Aug 31, 2022
Merged

[GCP] Add GKE data stream#4098
4 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 30, 2022

Copy link
Copy Markdown

What does this PR do?

Adds gke data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ghost ghost added Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Aug 30, 2022
@elasticmachine

elasticmachine commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-31T09:51:25.629+0000

  • Duration: 18 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 78
Skipped 0
Total 78

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Aug 30, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.655
Classes 100.0% (5/5) 💚 2.655
Methods 92.391% (85/92) 👍 2.516
Lines 95.752% (1375/1436) 👍 5.018
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review August 30, 2022 11:05
@ghost
ghost requested review from a team as code owners August 30, 2022 11:05
endorama
endorama approved these changes Aug 31, 2022
View reviewed changes

@endorama endorama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 small enhancements to the docs, everything else looks good to me!
Comment thread packages/gcp/_dev/build/docs/gke.md Outdated
Comment thread packages/gcp/_dev/build/docs/gke.md Outdated
@endorama

endorama commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

@gpop63 feel free to merge this once the CI is green!
@ghost
ghost merged commit bafdd2a into elastic:main Aug 31, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 13, 2022
Merged
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
gpop63 @endorama
[GCP] Add GKE data stream (elastic#4098)
af0c553 
* add gke data stream

* Update packages/gcp/_dev/build/docs/gke.md

* Update packages/gcp/_dev/build/docs/gke.md

* update docs

Co-authored-by: Edoardo Tenani <526307+endorama@users.noreply.github.com>
Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants

@elasticmachine @endorama @mrg-elastic