Skip to content

[ti_abusech] Change abusech.malwarebazaar.code_sign to Nested field - #4102

Merged
efd6 merged 3 commits into
elastic:mainfrom
legoguy1000:4092-malwarebazaar-codesign
Sep 6, 2022
Merged

[ti_abusech] Change abusech.malwarebazaar.code_sign to Nested field#4102
efd6 merged 3 commits into
elastic:mainfrom
legoguy1000:4092-malwarebazaar-codesign

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes a field mapping exception with abusech.malwarebazaar.code_sign. Changed the field mapping to Nested from Keyword.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@legoguy1000
legoguy1000 requested a review from a team as a code owner August 31, 2022 00:13
@elasticmachine

elasticmachine commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-05T23:36:42.252+0000

  • Duration: 18 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
efd6
efd6 reviewed Aug 31, 2022
View reviewed changes
Comment thread packages/ti_abusech/changelog.yml Outdated
@efd6

efd6 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

/test
@efd6

efd6 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

There is probably more to this than just changing the mapping. See elastic/beats#31552.
@elasticmachine

elasticmachine commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚 2.896
Classes 100.0% (4/4) 💚 2.896
Methods 100.0% (51/51) 💚 10.424
Lines 89.636% (493/550) 👎 -2.116
Conditionals 100.0% (0/0) 💚
@efd6

efd6 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

/test
@legoguy1000

legoguy1000 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

@efd6 can we rerun tests?
@efd6

efd6 commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

/test
@legoguy1000

legoguy1000 commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

@efd6 GTG??
efd6
efd6 approved these changes Sep 6, 2022
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6
efd6 merged commit 2c9e5fb into elastic:main Sep 6, 2022
@andrewkroh andrewkroh mentioned this pull request Sep 13, 2022
Merged
@chrisberkhout chrisberkhout mentioned this pull request Apr 16, 2024
Merged
4 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@legoguy1000
[ti_abusech] Change abusech.malwarebazaar.code_sign to Nested field (e…
8226f2c 
…lastic#4102)

* [ti_abusech]  Change abusech.malwarebazaar.code_sign to Nested field

* updates per comment

* Added Cert thumprint to hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@legoguy1000 @elasticmachine @efd6