Skip to content

[Vsphere] Fix optional domain in grok pattern - #4120

Merged
ishleenk17 merged 2 commits into
elastic:mainfrom
legoguy1000:4109-vsphere-update
Sep 21, 2022
Merged

[Vsphere] Fix optional domain in grok pattern#4120
ishleenk17 merged 2 commits into
elastic:mainfrom
legoguy1000:4109-vsphere-update

Conversation

@legoguy1000

@legoguy1000 legoguy1000 commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Updates grok pattern to make domain field optional
  • Updates to ECS 8.4

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@legoguy1000
legoguy1000 requested a review from a team as a code owner September 1, 2022 20:02
@elasticmachine

elasticmachine commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-15T07:41:18.956+0000

  • Duration: 17 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 18
Skipped 0
Total 18

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@legoguy1000

legoguy1000 commented Sep 6, 2022

Copy link
Copy Markdown
Contributor Author

@ShourieG can u review?
@agithomas

agithomas commented Sep 15, 2022

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Sep 15, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.674
Classes 100.0% (1/1) 💚 2.674
Methods 100.0% (18/18) 💚 10.252
Lines 89.13% (41/46) 👎 -2.312
Conditionals 100.0% (0/0) 💚
@legoguy1000

legoguy1000 commented Sep 19, 2022

Copy link
Copy Markdown
Contributor Author

Can this be merged?
ishleenk17
ishleenk17 reviewed Sep 20, 2022
View reviewed changes
Comment thread packages/vsphere/data_stream/log/elasticsearch/ingest_pipeline/default.yml
ishleenk17
ishleenk17 approved these changes Sep 20, 2022
View reviewed changes

@ishleenk17 ishleenk17 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@legoguy1000

legoguy1000 commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

@ishleenk17 Can this be merged?
@ishleenk17
ishleenk17 merged commit d3cfac0 into elastic:main Sep 21, 2022
@legoguy1000
legoguy1000 deleted the 4109-vsphere-update branch September 21, 2022 13:01
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@legoguy1000
[Vsphere] Fix optional domain in grok pattern (elastic#4120)
d589e86 
* [Vsphere[ Fix optional domain n grok pattern

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@legoguy1000 @elasticmachine @agithomas @ishleenk17