Skip to content

Kafka sasl mechanism - #4154

Merged
lalit-satapathy merged 3 commits into
elastic:mainfrom
lalit-satapathy:kafka-sasl-mechanism
Sep 8, 2022
Merged

Kafka sasl mechanism#4154
lalit-satapathy merged 3 commits into
elastic:mainfrom
lalit-satapathy:kafka-sasl-mechanism

Conversation

@lalit-satapathy

@lalit-satapathy lalit-satapathy commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

kafka integration will be passing down sasl.mechanism for consumergroup & partition data_streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Author's Checklist

  • Review Kafka metricbeat yml for sasl mechanism input

How to test this PR locally

  • Verify that the config is populated in the generated policy file.
  • No Kafka system test for now.

Related issues

Screenshots

      - id: kafka/metrics-kafka.partition-2b7de019-5e65-4fc2-a011-2e80100604bf
        data_stream:
          dataset: kafka.partition
          type: metrics
        metricsets:
          - partition
        period: 10s
        hosts:
          - 'localhost:9092'
        username: u1
        password: p1
        sasl.mechanism: SCRAM-SHA-256
@lalit-satapathy lalit-satapathy added bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team labels Sep 7, 2022
@lalit-satapathy lalit-satapathy self-assigned this Sep 7, 2022
@elasticmachine

elasticmachine commented Sep 7, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T13:20:47.676+0000

  • Duration: 14 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.814
Classes 100.0% (1/1) 💚 2.814
Methods 72.222% (13/18) 👎 -17.202
Lines 77.778% (56/72) 👎 -13.174
Conditionals 100.0% (0/0) 💚
@lalit-satapathy
lalit-satapathy marked this pull request as ready for review September 7, 2022 13:37
@lalit-satapathy
lalit-satapathy requested a review from a team as a code owner September 7, 2022 13:37
@ManojS-shetty
ManojS-shetty self-requested a review September 7, 2022 13:40

@ManojS-shetty ManojS-shetty left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lalit-satapathy
lalit-satapathy merged commit 3539e76 into elastic:main Sep 8, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Support SASL mechanism.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Service-Integrations Label for the Observability Service Integrations team

3 participants