Skip to content

feat: add aws additional auth options - #4168

Merged
olegsu merged 1 commit into
elastic:mainfrom
olegsu:aws-auth
Sep 11, 2022
Merged

feat: add aws additional auth options#4168
olegsu merged 1 commit into
elastic:mainfrom
olegsu:aws-auth

Conversation

@olegsu

@olegsu olegsu commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

Add additional AWS auth options (https://github.com/elastic/security-team/issues/4495)

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Related https://github.com/elastic/security-team/issues/4495

Screenshots

image
@olegsu
olegsu requested a review from a team as a code owner September 8, 2022 11:59
@elasticmachine

elasticmachine commented Sep 8, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-11T07:25:26.380+0000

  • Duration: 13 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@olegsu

olegsu commented Sep 8, 2022

Copy link
Copy Markdown
Contributor Author

/test
ofiriro3
ofiriro3 approved these changes Sep 8, 2022
View reviewed changes

@ofiriro3 ofiriro3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
@ofiriro3

ofiriro3 commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

I am not sure that the integration CI error is related to your work - please double check me
@orouz

orouz commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

LGTM

just to be sure, can you please verify that after creating an integration, the agent policy still includes our runtime config?

Screen Shot 2022-09-08 at 17 56 58
@elasticmachine

elasticmachine commented Sep 11, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.874
Classes 100.0% (0/0) 💚 2.874
Methods 25.0% (1/4) 👎 -64.776
Lines 100.0% (0/0) 💚 8.181
Conditionals 100.0% (0/0) 💚
@orouz orouz mentioned this pull request Sep 11, 2022
Merged
4 tasks
@olegsu

olegsu commented Sep 11, 2022

Copy link
Copy Markdown
Contributor Author

@orouz
Seems ok
image
@olegsu
olegsu merged commit 32ae490 into elastic:main Sep 11, 2022
@kfirpeled kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@olegsu
feat: add aws additional auth options (elastic#4168)
9fd6d31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Cloud Security Cloud Security team [elastic/cloud-security-posture]

5 participants

@olegsu @elasticmachine @ofiriro3 @orouz @kfirpeled