docs: add eks auth by olegsu · Pull Request #4332 · elastic/integrations

olegsu · 2022-09-28T11:11:15Z

What does this PR do?

Document the options for cloudbeat the authenticate when running in EKS cluster.

This will close elastic/cloudbeat#403

elasticmachine · 2022-09-28T11:14:24Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2022-10-18T07:14:48.678+0000
Duration: 14 min 53 sec

Test stats 🧪

Test	Results
Failed	0
Passed	2
Skipped	0
Total	2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

kfirpeled · 2022-09-28T15:21:57Z

@tinnytintin10 can you review this one? this PR contains only a change in the documentation

oren-zohar · 2022-10-02T13:41:38Z

/test

tinnytintin10

@olegsu I removed the kustomize example you used out of the readme. We'll cover it in the getting started guide of our docs.

tinnytintin10 · 2022-10-05T23:21:15Z

@benironside can you please read through the readme here and provide feedback? The goal here is not to include an in-depth getting started guide but instead to point them to the docs that we're updating.

benironside

Looks great overall, left some suggestions for your consideration, I hope they're helpful.

benironside

Left one more comment

benironside

More comments

tinnytintin10 · 2022-10-12T20:37:50Z

@oren-zohar @olegsu can y'all review the "Requirments" section of the read me for accuracy?

@benironside I made some final updates to the top of the issue- can you review it one last time?

Thanks all!

olegsu

Few notes about the default attached role

elasticmachine · 2022-10-13T20:26:03Z

🌐 Coverage report

Name	Metrics % (`covered/total`)	Diff
Packages	100.0% (`0/0`)	💚
Files	100.0% (`0/0`)	💚 2.759
Classes	100.0% (`0/0`)	💚 2.759
Methods	25.0% (`1/4`)	👎 -65.249
Lines	100.0% (`0/0`)	💚 8.499
Conditionals	100.0% (`0/0`)	💚

benironside

A few minor revisions

tinnytintin10 · 2022-10-14T17:40:03Z

A few minor revisions

Thanks, @benironside! I have applied your suggestion.

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

2. Adding links to the documentation for the various pages we mention

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* docs: add eks auth * content, wording and structure updates * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * 1. Adding more clarity to the overview section of the read me 2. Adding links to the documentation for the various pages we mention * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * struct updates * update hyperlink * fixing inner navigation links * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * adding oleg's feedback * updating spell mistakes and grammer along with struct updates * updating changelog and mani to resolve conflict(s) * add right links to using KSPM table * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * Update packages/cloud_security_posture/docs/README.md Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com> * chore: update version Co-authored-by: tinnytintin10 <tinsae.erkailo@elastic.co> Co-authored-by: Tinsae Erkailo <53792284+tinnytintin10@users.noreply.github.com> Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

olegsu added the docs label Sep 28, 2022

olegsu requested a review from a team as a code owner September 28, 2022 11:11

olegsu force-pushed the kspm-aws branch 2 times, most recently from d45a8af to 49da2cd Compare September 28, 2022 11:12

olegsu force-pushed the kspm-aws branch from 49da2cd to 8ecd8e2 Compare September 28, 2022 12:16

tinnytintin10 self-requested a review October 3, 2022 17:51

tinnytintin10 requested changes Oct 4, 2022

View reviewed changes

tinnytintin10 requested a review from benironside October 5, 2022 23:19

benironside reviewed Oct 10, 2022

View reviewed changes

Comment thread packages/cloud_security_posture/docs/README.md Outdated

benironside reviewed Oct 11, 2022

View reviewed changes

olegsu commented Oct 13, 2022

View reviewed changes

Comment thread packages/cloud_security_posture/docs/README.md Outdated

olegsu commented Oct 13, 2022

View reviewed changes

Comment thread packages/cloud_security_posture/docs/README.md Outdated

olegsu commented Oct 13, 2022

View reviewed changes

tinnytintin10 approved these changes Oct 13, 2022

View reviewed changes

benironside reviewed Oct 14, 2022

View reviewed changes

Comment thread packages/cloud_security_posture/docs/README.md Outdated

Comment thread packages/cloud_security_posture/docs/README.md Outdated

Comment thread packages/cloud_security_posture/docs/README.md Outdated

oren-zohar approved these changes Oct 14, 2022

View reviewed changes

olegsu and others added 6 commits October 18, 2022 10:12

docs: add eks auth

cfcc7ff

content, wording and structure updates

3e075a3

Update packages/cloud_security_posture/docs/README.md

18bf2c2

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

cc637f5

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

0370759

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

30b3a45

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

tinnytintin10 and others added 22 commits October 18, 2022 10:12

Update packages/cloud_security_posture/docs/README.md

94b666c

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

e59725c

suggestion by Ben Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

d300f46

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

675b947

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

444e147

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

549b758

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

bdca822

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

1. Adding more clarity to the overview section of the read me

1eab218

2. Adding links to the documentation for the various pages we mention

Update packages/cloud_security_posture/docs/README.md

db35399

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

be3e483

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

struct updates

fb4f5fd

update hyperlink

ed295e0

fixing inner navigation links

2e6fc7c

Update packages/cloud_security_posture/docs/README.md

65a8def

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

a8378d4

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

adding oleg's feedback

1a590b7

updating spell mistakes and grammer along with struct updates

b9c5a17

updating changelog and mani to resolve conflict(s)

d23cfa4

add right links to using KSPM table

6250652

Update packages/cloud_security_posture/docs/README.md

00d43c7

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

Update packages/cloud_security_posture/docs/README.md

2945e12

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

chore: update version

3281c4a

olegsu force-pushed the kspm-aws branch from 508a97a to 3281c4a Compare October 18, 2022 07:14

olegsu merged commit ad08aaa into elastic:main Oct 18, 2022

kfirpeled added the Team:Cloud Security Cloud Security team [elastic/cloud-security-posture] label Jun 26, 2023

andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Jul 1, 2025

Uh oh!

Conversation

olegsu commented Sep 28, 2022

What does this PR do?

elasticmachine commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

kfirpeled commented Sep 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

oren-zohar commented Oct 2, 2022

tinnytintin10 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

tinnytintin10 commented Oct 5, 2022

benironside left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

benironside left a comment

Choose a reason for hiding this comment

Uh oh!

benironside left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tinnytintin10 commented Oct 12, 2022

Uh oh!

Uh oh!

olegsu left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🌐 Coverage report

benironside left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tinnytintin10 commented Oct 14, 2022

Labels

7 participants

elasticmachine commented Sep 28, 2022 •

edited

Loading

kfirpeled commented Sep 28, 2022 •

edited

Loading

tinnytintin10 left a comment •

edited

Loading

elasticmachine commented Oct 13, 2022 •

edited

Loading