Skip to content

gcp: fix type of dns.answers.ttl - #4371

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:4361-gcp
Oct 5, 2022
Merged

gcp: fix type of dns.answers.ttl#4371
efd6 merged 1 commit into
elastic:mainfrom
efd6:4361-gcp

Conversation

@efd6

@efd6 efd6 commented Oct 3, 2022

Copy link
Copy Markdown
Contributor

What does this PR do?

This converts dns.answers.ttl to long during document parsing to conform to ECS spec for this field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@elasticmachine

elasticmachine commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-04T20:34:01.887+0000

  • Duration: 19 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 82
Skipped 0
Total 82

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown

🚀 Benchmarks report

Package gcp 👍(3) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
loadbalancing_logs 3584.23 2932.55 -651.68 (-18.18%) 💔

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Oct 3, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚 2.573
Classes 100.0% (5/5) 💚 2.573
Methods 90.816% (89/98) 👍 0.636
Lines 95.752% (1375/1436) 👍 4.17
Conditionals 100.0% (0/0) 💚
@efd6 efd6 self-assigned this Oct 3, 2022
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Oct 3, 2022
@efd6
efd6 marked this pull request as ready for review October 3, 2022 23:29
@efd6
efd6 requested review from a team as code owners October 3, 2022 23:29
@elasticmachine

elasticmachine commented Oct 3, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6
efd6 merged commit 1bde5c8 into elastic:main Oct 5, 2022
@efd6
efd6 deleted the 4361-gcp branch February 5, 2025 22:06
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
gcp: fix type of dns.answers.ttl (elastic#4371)
c14387f 
Convert dns.answers.ttl to long to conform to the ECS spec for this field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants

@efd6 @elasticmachine @endorama