Skip to content

[MongoDB]Adding username and password to handlebar file - #4381

Merged
ManojS-shetty merged 2 commits into
elastic:mainfrom
ManojS-shetty:mongodb-metrics-bugfix
Oct 10, 2022
Merged

[MongoDB]Adding username and password to handlebar file#4381
ManojS-shetty merged 2 commits into
elastic:mainfrom
ManojS-shetty:mongodb-metrics-bugfix

Conversation

@ManojS-shetty

@ManojS-shetty ManojS-shetty commented Oct 5, 2022

Copy link
Copy Markdown
Contributor
  • Bug

What does this PR do?

Updated the username and password variable in the template file for metrics data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone the PR.
  • Run the elastic-package stack up command.
  • Add the mongoDb integration.
  • In Integration UI provide all host related details.
  • Enrol the elastic agent.
  • MongoDB Metrics should be flowing to the Elastic-search.

Related issues
@ManojS-shetty
Adding username and password to handlebar file
36bc5fc 
	modified:   packages/mongodb/changelog.yml
	modified:   packages/mongodb/data_stream/metrics/agent/stream/stream.yml.hbs
	modified:   packages/mongodb/manifest.yml
@elasticmachine

elasticmachine commented Oct 5, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Oct 5, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-05T06:36:02.909+0000

  • Duration: 14 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 29
Skipped 0
Total 29

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Oct 5, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.389
Classes 100.0% (3/3) 💚 2.389
Methods 81.818% (27/33) 👎 -8.905
Lines 84.158% (85/101) 👎 -6.555
Conditionals 100.0% (0/0) 💚
@ManojS-shetty
Updated changelog entry
1db9d6c 
	modified:   packages/mongodb/changelog.yml
@ManojS-shetty
ManojS-shetty marked this pull request as ready for review October 5, 2022 07:09
@ManojS-shetty
ManojS-shetty requested a review from a team as a code owner October 5, 2022 07:09
@ManojS-shetty ManojS-shetty mentioned this pull request Oct 5, 2022
Closed
@ManojS-shetty ManojS-shetty self-assigned this Oct 5, 2022
@ManojS-shetty ManojS-shetty added the Team:Service-Integrations Label for the Observability Service Integrations team label Oct 5, 2022
agithomas
agithomas approved these changes Oct 10, 2022
View reviewed changes

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
@ManojS-shetty
ManojS-shetty merged commit b83ddb6 into elastic:main Oct 10, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@ManojS-shetty
[MongoDB]Adding username and password to handlebar file (elastic#4381)
e668921 
* Adding username and password to handlebar file
	modified:   packages/mongodb/changelog.yml
	modified:   packages/mongodb/data_stream/metrics/agent/stream/stream.yml.hbs
	modified:   packages/mongodb/manifest.yml

* Updated changelog entry
	modified:   packages/mongodb/changelog.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Service-Integrations Label for the Observability Service Integrations team

3 participants

@ManojS-shetty @elasticmachine @agithomas