Skip to content

getting rid of internal links - #4470

Merged
olegsu merged 4 commits into
mainfrom
csp_readme_updates
Oct 18, 2022
Merged

getting rid of internal links#4470
olegsu merged 4 commits into
mainfrom
csp_readme_updates

Conversation

@tinnytintin10

Copy link
Copy Markdown
Contributor

this PR removed the internal links in the readme of the CSP integration that doesn't work when viewing the integration in kibana

@tinnytintin10
tinnytintin10 requested a review from a team as a code owner October 18, 2022 15:28
@elasticmachine

elasticmachine commented Oct 18, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-18T16:25:04.742+0000

  • Duration: 14 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.492
Classes 100.0% (0/0) 💚 2.492
Methods 25.0% (1/4) 👎 -65.345
Lines 100.0% (0/0) 💚 8.442
Conditionals 100.0% (0/0) 💚

@oren-zohar oren-zohar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

@olegsu
olegsu force-pushed the csp_readme_updates branch from d7e5dbe to e99df30 Compare October 18, 2022 16:24
@olegsu
olegsu merged commit ff38bf7 into main Oct 18, 2022
@oren-zohar
oren-zohar deleted the csp_readme_updates branch October 18, 2022 18:57
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* getting rid of internal links

* bumping up integration version

* removing section toc

* remove the drop down section for iam policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants