Skip to content

[azure_metrics] add compute_vm_scaleset pipeline test - #4513

Merged
4 commits merged into
mainfrom
unknown repository
Nov 2, 2022
Merged

[azure_metrics] add compute_vm_scaleset pipeline test#4513
4 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 27, 2022

Copy link
Copy Markdown

What does this PR do?

Adds compute_vm_scaleset pipeline test.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@elasticmachine

elasticmachine commented Oct 27, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-02T15:03:28.296+0000

  • Duration: 14 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 133
Skipped 0
Total 133

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@ghost
ghost force-pushed the add_compute-vm-scaleset_pipeline_test branch from 132166c to 8ec8e09 Compare October 27, 2022 21:20
@elasticmachine

elasticmachine commented Oct 27, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Oct 27, 2022 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.525
Classes 100.0% (2/2) 💚 2.525
Methods 71.429% (20/28) 👎 -19.302
Lines 100.0% (14/14) 💚 8.496
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review October 28, 2022 11:39
@ghost
ghost self-requested a review as a code owner October 28, 2022 11:39
@ghost ghost added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Oct 28, 2022
zmoog
zmoog reviewed Oct 28, 2022
View reviewed changes
Comment thread packages/azure_metrics/changelog.yml Outdated
@@ -1,3 +1,8 @@
- version: "1.1.1"

@zmoog zmoog Oct 28, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we bumping the patch version here, while on #4512 we are bumping the minor version?

@ghost ghost Nov 1, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought we would merge #4512 first, then this one. I fixed and bumped patch versions in both PRs.
zmoog
zmoog approved these changes Nov 2, 2022
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ghost
ghost merged commit dd312c5 into elastic:main Nov 2, 2022
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Gabriel Pop
[azure_metrics] add compute_vm_scaleset pipeline test (elastic#4513)
a47d5d6 
* fix pipeline name

* add compute_vm_scaleset pipeline test

* bump patch version
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

3 participants

@elasticmachine @zmoog @mrg-elastic