Skip to content

Support list of dynamic counter name. - #4637

Merged
ritalwar merged 4 commits into
elastic:mainfrom
ritalwar:mssql_dynamic_counter_4432
Nov 15, 2022
Merged

Support list of dynamic counter name.#4637
ritalwar merged 4 commits into
elastic:mainfrom
ritalwar:mssql_dynamic_counter_4432

Conversation

@ritalwar

@ritalwar ritalwar commented Nov 14, 2022

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR adds support for list of dynamic counter names.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Add Microsoft Sql Server integration, Enable performance metrics, give dynamic counter input and see the metrics for that counter in Kibana

Screenshots

Screenshot 2022-11-14 at 8 56 51 PM

Screenshot 2022-11-14 at 8 44 22 PM

@ritalwar ritalwar self-assigned this Nov 14, 2022
@elasticmachine

elasticmachine commented Nov 14, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-15T11:12:17.304+0000

  • Duration: 16 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 14, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 2.542
Classes 100.0% (2/2) 💚 2.542
Methods 93.333% (28/30) 👍 2.471
Lines 100.0% (1238/1238) 💚 8.375
Conditionals 100.0% (0/0) 💚
@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ritalwar
ritalwar marked this pull request as ready for review November 15, 2022 11:55
@ritalwar
ritalwar requested review from a team as code owners November 15, 2022 11:55
@ManojS-shetty
ManojS-shetty self-requested a review November 15, 2022 13:55
@ritalwar
ritalwar merged commit 0aa29ac into elastic:main Nov 15, 2022
@Danouchka

Copy link
Copy Markdown

Question: is this working in the setting %pool%,%block%,%buffer%,%lock% ?
I think not. @lalit-satapathy : please can you check ?

@Danouchka

Copy link
Copy Markdown

OK answered by @ritalwar
I added a 2nd integration, would be better to be able to add rows for every dynamic counter name pattern ?
@lalit-satapathy : your opinion on this please ?
Can it be done ?

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Support list of dynamic counter name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants