Skip to content

[Enhancement] [PANW] Make enhancement in connector with best practices implementation - #4670

Merged
P1llus merged 4 commits into
elastic:mainfrom
vinit-chauhan:package-panw-3.3.0
Nov 19, 2022
Merged

[Enhancement] [PANW] Make enhancement in connector with best practices implementation#4670
P1llus merged 4 commits into
elastic:mainfrom
vinit-chauhan:package-panw-3.3.0

Conversation

@vinit-chauhan

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

Make enhancement in PANW connector with listed best practices.

Sr. No. Best Practices
1 Verify best practices test cases are executed
2 Verify all automated tests
3 Verify default values of port for TCP, UDP or HTTP Endpoint Input
4 Verify that the data is ingested in kibana for in interval
5 Verify all fields are correctly mapped for all Data streams
6 Verify related.ip field in datastream
7 Verify related.hash field in datastream
8 Verify related.hosts field in datastream
9 Verify related.user field in datastream
10 Verify network.protocol is in lowercase form
11 Verify network.transport is in lowercase form
12 Verify very long syslog message
13 Verify on-failure on convert processor
14 Verify MAC address should be separated by dash and value should be an array and MAC address should be valid. MAC address is in uppercase form
15 Verify visualizations are not linked with library
16 Verify format of title of visualizations
17 Verify format of title of dashboard
18 Verify Datastream Dashboard
19 Verify filters in visualizations
20 Verify visualizations in different browser
21 Verify README file

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/panw directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image

…urce.user.name & source.user.domain properly
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner November 17, 2022 09:08
@vinit-chauhan vinit-chauhan added enhancement New feature or request Team:Security-External Integrations Integration:panw Palo Alto Next-Gen Firewall labels Nov 17, 2022
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Nov 17, 2022

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-18T11:36:55.229+0000

  • Duration: 195 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Nov 17, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (15/15) 💚
Classes 100.0% (15/15) 💚
Methods 98.529% (67/68)
Lines 93.797% (3251/3466)
Conditionals 100.0% (0/0) 💚
@P1llus
P1llus merged commit bc1802f into elastic:main Nov 19, 2022
@vinit-chauhan
vinit-chauhan deleted the package-panw-3.3.0 branch April 1, 2026 23:56
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…s implementation (elastic#4670)

* Add an on_failure processor to the date processor and mapped field source.user.name & source.user.domain properly

* Update changelog entry

* Resolved merege conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:panw Palo Alto Next-Gen Firewall

3 participants