Skip to content

[Enhancement] [Trend Micro Vision One] Update the Pagination Termination Condition - #4701

Merged
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:package-trend-micro-vision-one-0.2.1
Nov 25, 2022
Merged

[Enhancement] [Trend Micro Vision One] Update the Pagination Termination Condition#4701
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:package-trend-micro-vision-one-0.2.1

Conversation

@vinit-chauhan

@vinit-chauhan vinit-chauhan commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

Update the Pagination Termination Condition for Trend Micro Vision One connector.

Current condition for pagination termination contains [[else]][[.last_response.terminate_pagination]][[end]] which results in error logs when pagination is completed.

Removing this else condition will not result in error logs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/trend_micro_vision_one directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image
image
image
image
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner November 23, 2022 10:22
@elasticmachine

elasticmachine commented Nov 23, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Nov 23, 2022

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine

elasticmachine commented Nov 23, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-23T10:24:15.790+0000

  • Duration: 16 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Nov 23, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (3/3) 💚
Classes 100.0% (3/3) 💚
Methods 100.0% (43/43) 💚
Lines 95.42% (1500/1572) ❕
Conditionals 100.0% (0/0) 💚
@P1llus
P1llus merged commit 3a5ac1d into elastic:main Nov 25, 2022
@elasticmachine

elasticmachine commented Nov 25, 2022

Copy link
Copy Markdown

Package trend_micro_vision_one - 0.2.1 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one
@vinit-chauhan
vinit-chauhan deleted the package-trend-micro-vision-one-0.2.1 branch April 1, 2026 23:56
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@vinit-chauhan
[Enhancement] [Trend Micro Vision One] Update the Pagination Terminat…
e21b386 
…ion Condition (elastic#4701)

* Update the pagination termination condition

* Update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@vinit-chauhan @elasticmachine @P1llus