Skip to content

[TI OTX] Adding drop for empty documents - #4877

Merged
P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_otx_empty
Dec 21, 2022
Merged

[TI OTX] Adding drop for empty documents#4877
P1llus merged 2 commits into
elastic:mainfrom
P1llus:package_otx_empty

Conversation

@P1llus

@P1llus P1llus commented Dec 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

When OTX returns a count of 0, we should drop the empty documents

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@P1llus P1llus added bug Something isn't working, use only for issues Team:Security-External Integrations labels Dec 21, 2022
@P1llus
P1llus requested a review from a team as a code owner December 21, 2022 09:43
@elasticmachine

elasticmachine commented Dec 21, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
ShourieG
ShourieG approved these changes Dec 21, 2022
View reviewed changes

@ShourieG ShourieG left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
kcreddy
kcreddy approved these changes Dec 21, 2022
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@elasticmachine

elasticmachine commented Dec 21, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-21T09:44:24.997+0000

  • Duration: 14 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Dec 21, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.421
Classes 100.0% (1/1) 💚 2.421
Methods 100.0% (11/11) 💚 8.383
Lines 76.812% (106/138) 👎 -15.437
Conditionals 100.0% (0/0) 💚
@P1llus
P1llus merged commit 5aaba72 into elastic:main Dec 21, 2022
@elasticmachine

elasticmachine commented Dec 21, 2022

Copy link
Copy Markdown

Package ti_otx - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=ti_otx
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@P1llus
[TI OTX] Adding drop for empty documents (elastic#4877)
fd77b85 
* Adding possibility to drop empty documents otx

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

4 participants

@P1llus @elasticmachine @kcreddy @ShourieG