Skip to content

[m365_defender] Update API version for Incident data stream & Mark log data stream as deprecated - #4893

Merged
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:update-api-version
Dec 27, 2022
Merged

[m365_defender] Update API version for Incident data stream & Mark log data stream as deprecated#4893
P1llus merged 2 commits into
elastic:mainfrom
vinit-chauhan:update-api-version

Conversation

@vinit-chauhan

@vinit-chauhan vinit-chauhan commented Dec 23, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Type of change

  • Enhancement

What does this PR do?

  • Update API version for Incident data stream.
  • Mark the log data stream as deprecated because it's using the older Defender APIs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/m365_defender directory.
  • Run the following command to run tests.

elastic-package test

Related issues

Screenshots

image (1)
image (2)
image (3)
image (4)
@vinit-chauhan
vinit-chauhan requested a review from a team as a code owner December 23, 2022 05:30
@elasticmachine

elasticmachine commented Dec 23, 2022

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine

elasticmachine commented Dec 23, 2022 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-23T05:33:57.762+0000

  • Duration: 14 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Dec 23, 2022

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 1.705
Classes 100.0% (2/2) 💚 1.705
Methods 96.774% (30/31) 👍 5.374
Lines 94.335% (2298/2436) 👍 1.445
Conditionals 100.0% (0/0) 💚
kcreddy
kcreddy reviewed Dec 26, 2022
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vinit-elastic
Could you please confirm if the response schema across both beta and 1.0 is same?
Comment thread packages/m365_defender/_dev/build/docs/README.md
@vinit-chauhan

vinit-chauhan commented Dec 27, 2022

Copy link
Copy Markdown
Contributor Author

Hey @kcreddy - Yes, the response in both of the APIs is the same.
FWIW, the Security Graph API was beta previously and is now GA, therefore we updated it to v1.0.
P1llus
P1llus approved these changes Dec 27, 2022
View reviewed changes
Comment thread packages/m365_defender/_dev/build/docs/README.md
@P1llus
P1llus merged commit f4cf253 into elastic:main Dec 27, 2022
@elasticmachine

elasticmachine commented Dec 27, 2022

Copy link
Copy Markdown

Package m365_defender - 1.4.3 containing this change is available at https://epr.elastic.co/search?package=m365_defender
1 similar comment
@elasticmachine

elasticmachine commented Dec 27, 2022

Copy link
Copy Markdown

Package m365_defender - 1.4.3 containing this change is available at https://epr.elastic.co/search?package=m365_defender
@vinit-chauhan
vinit-chauhan deleted the update-api-version branch April 1, 2026 23:56
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@vinit-chauhan
[m365_defender] Update API version for Incident data stream & Mark lo…
cf6303b 
…g data stream as deprecated (elastic#4893)

* Update API version for incident data stream & Mark log data stream as deprecated

* Update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR

4 participants

@vinit-chauhan @elasticmachine @P1llus @kcreddy