Skip to content

[GCP] Migrate compute metrics dashboard to lens - #5038

Merged
endorama merged 7 commits into
elastic:mainfrom
tommyers-elastic:5015-migrate-gcp-compute-dashboard-to-lens
Mar 23, 2023
Merged

[GCP] Migrate compute metrics dashboard to lens#5038
endorama merged 7 commits into
elastic:mainfrom
tommyers-elastic:5015-migrate-gcp-compute-dashboard-to-lens

Conversation

@tommyers-elastic

@tommyers-elastic tommyers-elastic commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Migrates GCP compute metrics dashboard visualizations to lens. Adds top-level datastream filter to improve performance.

Note to reviewers: when migrating the 'Read/Write IO' and "Network sent/received' panels, I noticed that the existing aggregations are based on doc count, not top values of the metric. I thought this was a bit strange. The resulting charts are quite different, as you can see in the screenshots below. One additional change in the new panels, is that I have left the 'Other' groupings in the 'top values' aggs, which can be removed if deemed necessary.

Before:

Screenshot 2023-01-18 at 12 13 40
Screenshot 2023-01-18 at 12 13 46

After:

Screenshot 2023-01-18 at 12 13 55
Screenshot 2023-01-18 at 12 14 02

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Install and validate the new dashboard locally.

How to test this PR locally

cd packages/gcp
elastic-package build .
elastic-package stack up -d --services=package-registry
...

Related issues

Tracked by #5015.

@tommyers-elastic tommyers-elastic added the enhancement New feature or request label Jan 18, 2023
@tommyers-elastic
tommyers-elastic requested review from a team as code owners January 18, 2023 12:11
@mergify

mergify Bot commented Jan 18, 2023

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #5032. Mergify cannot evaluate rules on this PR. ⚠️

@elasticmachine

elasticmachine commented Jan 18, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-23T10:52:39.787+0000

  • Duration: 18 min 34 sec

Test stats 🧪

Test Results
Failed 0
Passed 59
Skipped 0
Total 59

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Jan 18, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 89.623% (95/106) 👎 -3.711
Lines 96.0% (1464/1525) 👎 -1.041
Conditionals 100.0% (0/0) 💚
@andrewkroh andrewkroh added the Integration:gcp Google Cloud Platform label Jan 18, 2023
@andrewkroh andrewkroh changed the title Migrate GCP compute metrics dashboard to lens Jan 18, 2023
@endorama

Copy link
Copy Markdown
Contributor

I installed the package in this PR but the dashboard does not seem to be updated, I still see the "Before" version. @tommyers-elastic do you have any suggestion? I started from scratch with a 8.6.0 stack started through elastic-package.

@endorama endorama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the dashboard looks good and works as expected. 2 minor comments:

  • it seems this PR builds upon #5032
  • tags (that have been exported through elastic-package) should not be added
Comment thread packages/gcp/kibana/tag/gcp-fleet-managed-default.json
Comment thread packages/gcp/changelog.yml Outdated
@tommyers-elastic
tommyers-elastic force-pushed the 5015-migrate-gcp-compute-dashboard-to-lens branch from fb77e54 to b01dbaa Compare January 19, 2023 14:21
@tommyers-elastic
tommyers-elastic requested a review from a user January 30, 2023 10:47

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the dashboard with data, the data stream filter is applied, seems fine to me!

@tommyers-elastic
tommyers-elastic dismissed endorama’s stale review January 30, 2023 14:27

changes are addressed in latest commit

@endorama endorama left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments address, lets get to main!! :shipit:

@botelastic

botelastic Bot commented Mar 1, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label Mar 1, 2023
@botelastic botelastic Bot removed the Stalled label Mar 23, 2023
@endorama endorama added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Mar 23, 2023
@endorama
endorama merged commit 52fb234 into elastic:main Mar 23, 2023
@elasticmachine

Copy link
Copy Markdown

Package gcp - 2.19.1 containing this change is available at https://epr.elastic.co/search?package=gcp

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Co-authored-by: Edoardo Tenani <edoardo.tenani@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:gcp Google Cloud Platform Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants