cef,infoblox_nios,keycloak,modsecurity,panw,pfsense,qnap_nas,snort,sonicwall: ensure timezones are strings - #5051
Merged
Merged
Conversation
efd6
added
bug
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
Contributor
Author
|
/test |
Contributor
Author
|
These all pass locally, so I'm not sure what is going on. |
Contributor
|
/test |
1 similar comment
Contributor
Author
|
/test |
…ap_nas,snort,sonicwall: ensure timezones are strings
efd6
force-pushed
the
5049-timezones
branch
3 times, most recently
from
January 27, 2023 05:21
811eabe to
a89bf1c
Compare
This depends on each stream container spawn getting a unique port and so distinguishing the docs.
This depends on file name differences.
Contributor
Author
ᕙ(⇀‸↼‶)ᕗ |
efd6
force-pushed
the
5049-timezones
branch
2 times, most recently
from
January 27, 2023 09:41
cdd3ad4 to
87ec81f
Compare
Contributor
Author
|
I'm going to back out the ms-dhcp, the error makes no sense. |
efd6
changed the title
efd6
marked this pull request as ready for review
January 27, 2023 10:07
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Jan 27, 2023
| {{/each}} | ||
| fields_under_root: true | ||
| fields: | ||
| tz_offset: {{tz_offset}} |
Contributor
There was a problem hiding this comment.
This raises the question of what should the behavior be. This field was not used in a pipeline (or presenting the manifest). And the event.timezone produced by the add_locale processor does not appear to be used anywhere.
Contributor
Author
There was a problem hiding this comment.
Yes, this was my confusion here. I saw it wasn't being used. I'll add time zone config to the processor.
Contributor
Author
There was a problem hiding this comment.
Looking into this further, it looks like the logs always have a time zone. So I think the removal is the correct thing to do here.
Contributor
There was a problem hiding this comment.
The time_stamp field in this test file does not have a TZ. And I think that time value is being parsed in the nginx-modsec pipeline. Maybe the value is always reported in UTC?
Contributor
Author
There was a problem hiding this comment.
I came up with a reasonably sane way to handle the insanity of disparate representations of time zone for cisco_meraki, so I bring that here.
Obligatory xkcd.
andrewkroh
approved these changes
Feb 6, 2023
|
Package cef - 2.6.1 containing this change is available at https://epr.elastic.co/search?package=cef |
|
Package infoblox_nios - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios |
|
Package keycloak - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=keycloak |
|
Package modsecurity - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=modsecurity |
|
Package panw - 3.5.1 containing this change is available at https://epr.elastic.co/search?package=panw |
|
Package pfsense - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=pfsense |
|
Package qnap_nas - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=qnap_nas |
|
Package snort - 1.4.1 containing this change is available at https://epr.elastic.co/search?package=snort |
|
Package sonicwall_firewall - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=sonicwall_firewall |
andrewkroh
added
Integration:infoblox_nios
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…nicwall: ensure timezones are strings (elastic#5051)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This ensures that timezone offsets in the form "+0n00" are not interpreted as octal integers.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots