[Azure Application Gateway] Fix parsing error client port is blank and adjust for timeStamp - #5073
Merged
Conversation
Pipeline fails to parse Azure Application Gateway logs when the client port field exists with no data. ``` error.message : For input string: \"\" convert ```
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
nicpenning
changed the title
Contributor
|
Hey @nicpenning, thank you for contributing to the Azure Application Gateway integration with this fix! |
zmoog
self-requested a review
January 24, 2023 11:25
zmoog
added
bug
The fields are not in the same order but is very similar to other examples except with the blank clientPort field.
For some reason, the _ingest.timestamp is outside of the _source field. I have ommited it from here. Furthermore, it seems timestamp changed to timeStamp, so the pipeline will need to be updated.
nicpenning
changed the title
Contributor
Author
|
When I was going through and trying to provide some example data I stumbled upon another issue which was the timestamp in the document I had was using timeStamp so I added that to the pipeline. |
zmoog
requested changes
Jan 26, 2023
zmoog
reviewed
Jan 27, 2023
Contributor
Author
|
Not sure where my comment went, but yes, this data is from the Azure Gov cloud. 😀 |
zmoog
requested changes
Jan 27, 2023
Contributor
Author
|
Okay @zmoog, how is everything looking now? |
zmoog
approved these changes
Jan 31, 2023
Contributor
|
/test |
🌐 Coverage report
|
Contributor
Author
|
Any further action needed for this? I don't want this to get too stale. |
Contributor
Yep, someone must check and fix the errors in the CI pipeline. I can't merge the PR if they aren't all green. Let me take a look at the failing one. |
Contributor
|
/test |
The pipeline test was failing due to differences between the expected
and actual document.
I fixed the pipeline tests error by regenerating the expected document
using the following command:
elastic-package test pipeline --generate
The `--generate` option runs the pipeline and save the result in a
test result file.
Contributor
|
@nicpenning, the bot will comment on this PR when the new version is available. Thank you for your contribution and your patience in these back and forth! |
|
Package azure - 1.5.6 containing this change is available at https://epr.elastic.co/search?package=azure |
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
…d adjust for timeStamp (elastic#5073) * Fix parsing error when no client port exists Pipeline fails to parse Azure Application Gateway logs when the client port field exists with no data. ``` error.message : For input string: \"\" convert ``` * Update changelog.yml * Update manifest.yml * Update test-application-gateway-raw.log The fields are not in the same order but is very similar to other examples except with the blank clientPort field. * Update test-application-gateway-raw.log-expected.json For some reason, the _ingest.timestamp is outside of the _source field. I have ommited it from here. Furthermore, it seems timestamp changed to timeStamp, so the pipeline will need to be updated. * Add new timeStamp field * Update changelog.yml * Change to lowercase timeStamp instead * Change the lowercase to rename * Correct field rename * Regenerate the expected test document The pipeline test was failing due to differences between the expected and actual document. I fixed the pipeline tests error by regenerating the expected document using the following command: elastic-package test pipeline --generate The `--generate` option runs the pipeline and save the result in a test result file. --------- Co-authored-by: Maurizio Branca <maurizio.branca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pipeline fails to parse Azure Application Gateway logs when the client port field exists with no data.
What does this PR do?
Checklist
changelog.ymlfile.