Skip to content

checkpoint: improve support for Checkpoint 81 - #5184

Merged
efd6 merged 2 commits into
elastic:mainfrom
efd6:5110-checkpoint
Feb 6, 2023
Merged

checkpoint: improve support for Checkpoint 81#5184
efd6 merged 2 commits into
elastic:mainfrom
efd6:5110-checkpoint

Conversation

@efd6

@efd6 efd6 commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

  • handle timezone
  • handle alternative structured data kv format

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

* handle timezone
* handle alternative structured data kv format
@elasticmachine

elasticmachine commented Feb 6, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-06T20:48:48.479+0000

  • Duration: 17 min 39 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Feb 6, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 5.882
Classes 100.0% (1/1) 💚 5.882
Methods 100.0% (16/16) 💚 15.493
Lines 84.835% (772/910) 👎 -10.891
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review February 6, 2023 06:35
@efd6
efd6 requested a review from a team as a code owner February 6, 2023 06:35
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible minor change, rest LGTM 👍🏼

],
"kind": "event",
"original": "\u003c85\u003e1 2023-01-13T10:10:16--5:00 172.16.2.9 CP-GW - Log [Fields@1.3.6.1.4.1.2620 inzone=\"DMZ\" outzone=\"External\" service_id=\"https\" src=\"81.2.69.192\" dst=\"81.2.69.142\" proto=\"6\" xlatesrc=\"81.2.69.144\" xlatedst=\"\" NAT_rulenum=\"1195\" NAT_addtnl_rulenum=\"0\" user=\"\" src_user_name=\"\" src_machine_name=\"\" src_user_dn=\"\" snid=\"\" dst_user_name=\"\" dst_machine_name=\"\" dst_user_dn=\"\" UP_match_table=\"TABLE_START\" ROW_START=\"0\" match_id=\"762\" layer_uuid=\"e2117254-df10-4a5d-8d42-cacc362e077b\" layer_name=\"DETOMPERMFW_2021 Security\" rule_uid=\"82434e2a-a72c-4a59-8422-a0269fc32e93\" rule_name=\"\" ROW_END=\"0\" UP_match_table=\"TABLE_END\" ProductName=\"VPN-1 \u0026 FireWall-1\" svc=\"443\" sport_svc=\"56530\" xlatedport_svc=\"\" xlatesport_svc=\"28493\" ProductFamily=\"Network\" ]",
"timezone": "-0500"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should be a : in event.timezone as per the ECS doc

@efd6
efd6 merged commit 6abc19a into elastic:main Feb 6, 2023
@elasticmachine

Copy link
Copy Markdown

Package checkpoint - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=checkpoint

@efd6
efd6 deleted the 5110-checkpoint branch February 5, 2025 22:11
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* handle timezone
* handle alternative structured data kv format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point

3 participants