[kibana] Mention elasticsearch data dependency in readme - #5215
Merged
jennypavlova merged 4 commits intoFeb 9, 2023
Merged
Conversation
jennypavlova
added
the
Team:Infra Monitoring UI - DEPRECATED
jennypavlova
marked this pull request as ready for review
February 8, 2023 15:33
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
| name: kibana | ||
| title: Kibana | ||
| version: 2.2.0-preview1 | ||
| version: 2.3.0-preview1 |
Contributor
There was a problem hiding this comment.
just for a better understanding.
Is there a way to go with the versioning here, like why 2.3.0 and not 2.2.1 since its a documentation update for example
Member
Author
There was a problem hiding this comment.
Good point! I was thinking about it but I wasn't sure if we usually use patch versions here. I changed it to 2.2.1
Contributor
There was a problem hiding this comment.
Yes same here 😄 I just looked up previous PRs on the same file and saw that they usually increase the patch version when it comes to documentation updates 👍
🌐 Coverage report
|
jennypavlova
deleted the
3974-kibana-mention-elasticsearch-data-dependency-in-readme
branch
February 9, 2023 10:38
orestisfl
pushed a commit
to orestisfl/integrations
that referenced
this pull request
May 15, 2026
* Add elastic data dependency in kibana README.md * Change version to 2.3.0-preview1 * Change version to 2.2.1-preview1 * Update build docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an explanation to the readme file that the elasticsearch data should be monitored in order to see Kibana data in Stack monitoring UI
Related issues
Screenshots