Skip to content

Update documentation for password - #5241

Merged
ritalwar merged 2 commits into
elastic:mainfrom
ritalwar:mssql_4198
Feb 13, 2023
Merged

Update documentation for password#5241
ritalwar merged 2 commits into
elastic:mainfrom
ritalwar:mssql_4198

Conversation

@ritalwar

@ritalwar ritalwar commented Feb 13, 2023

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR updates the Readme.md to specify URL encoding for passwords with special character.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2023-02-13 at 10 43 17 AM

Screenshot 2023-02-13 at 10 44 17 AM

@ritalwar
ritalwar marked this pull request as ready for review February 13, 2023 05:16
@ritalwar
ritalwar requested a review from a team as a code owner February 13, 2023 05:16
@elasticmachine

elasticmachine commented Feb 13, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-13T05:11:07.450+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 3.443
Classes 100.0% (2/2) 💚 3.443
Methods 93.333% (28/30) 👍 2.341
Lines 100.0% (1238/1238) 💚 8.617
Conditionals 100.0% (0/0) 💚
@elasticmachine

Copy link
Copy Markdown

Package microsoft_sqlserver - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

@agithomas agithomas mentioned this pull request Feb 13, 2023
4 tasks
bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
* Update documentation for password
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Update documentation for password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants