Skip to content

[AWS] Migrate DynamoDB metrics dashboard visualizations to lenses - #5288

Merged
4 commits merged into
mainfrom
unknown repository
May 12, 2023
Merged

[AWS] Migrate DynamoDB metrics dashboard visualizations to lenses#5288
4 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 15, 2023

Copy link
Copy Markdown

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
dynamodb_beforee

After:
dynamodb_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ghost ghost changed the title Migrate aws dynamodb vis to lens Feb 15, 2023
@elasticmachine

elasticmachine commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-09T02:05:17.324+0000

  • Duration: 51 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Feb 15, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -10.022
Lines 85.925% (7387/8597) 👎 -5.294
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review February 16, 2023 11:04
@ghost
ghost requested review from a team as code owners February 16, 2023 11:04
@ghost
ghost force-pushed the migrate_aws-dynamodb_vis_to_lens branch from 2c4d579 to 721cc2d Compare March 8, 2023 12:57
drewdaemon
drewdaemon approved these changes Mar 10, 2023
View reviewed changes

@drewdaemon drewdaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
@botelastic

botelastic Bot commented Apr 20, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic Bot added the Stalled label Apr 20, 2023
@botelastic botelastic Bot removed the Stalled label May 9, 2023
@zmoog zmoog self-assigned this May 11, 2023
zmoog
zmoog approved these changes May 11, 2023
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@ghost
ghost merged commit 3d28b48 into elastic:main May 12, 2023
@elasticmachine

elasticmachine commented May 12, 2023

Copy link
Copy Markdown

Package aws - 1.34.4 containing this change is available at https://epr.elastic.co/search?package=aws
@ghost ghost self-assigned this May 22, 2023
@rameshelastic rameshelastic mentioned this pull request May 29, 2023
Closed
15 tasks
@harnish-crest-data harnish-crest-data mentioned this pull request Jun 9, 2023
Closed
5 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Gabriel Pop
[AWS] Migrate DynamoDB metrics dashboard visualizations to lenses (el…
86c0c1b 
…astic#5288)

* add lenses and input control groups

* bump package version
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@elasticmachine @zmoog @drewdaemon @mrg-elastic