Skip to content

checkpoint: enhance processor error reporting - #5295

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:5108-checkpoint
Feb 17, 2023
Merged

checkpoint: enhance processor error reporting#5295
efd6 merged 1 commit into
elastic:mainfrom
efd6:5108-checkpoint

Conversation

@efd6

@efd6 efd6 commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Errors are made more informative and provide tags to allow programmatic repair.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Feb 16, 2023
@elasticmachine

elasticmachine commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-17T09:13:57.963+0000

  • Duration: 16 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Feb 16, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (16/16) 💚
Lines 85.275% (805/944) 👎 -10.968
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review February 16, 2023 04:18
@efd6
efd6 requested a review from a team as a code owner February 16, 2023 04:18
@elasticmachine

elasticmachine commented Feb 16, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Feb 17, 2023
View reviewed changes

@kcreddy kcreddy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, rest LGTM 👍🏼
Comment thread packages/checkpoint/data_stream/firewall/elasticsearch/ingest_pipeline/default.yml Outdated

@kcreddy kcreddy Feb 17, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value is pipeline_error as per the doc

@efd6 efd6 Feb 17, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6
efd6 merged commit 74f8fc4 into elastic:main Feb 17, 2023
@elasticmachine

elasticmachine commented Feb 17, 2023

Copy link
Copy Markdown

Package checkpoint - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=checkpoint
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@efd6 @agithomas
checkpoint: enhance processor error reporting (elastic#5295)
ef23928
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 @agithomas
checkpoint: enhance processor error reporting (elastic#5295)
4fbc807
@efd6
efd6 deleted the 5108-checkpoint branch February 5, 2025 22:09
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
checkpoint: enhance processor error reporting (elastic#5295)
bc2d696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint Check Point

3 participants

@efd6 @elasticmachine @kcreddy