Skip to content

[AWS] Migrate NATGateway metrics visualizations to lenses - #5426

Merged
9 commits merged into
mainfrom
unknown repository
Jun 7, 2023
Merged

[AWS] Migrate NATGateway metrics visualizations to lenses#5426
9 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 1, 2023

Copy link
Copy Markdown

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
natgateway_before

After:
natgateway_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ghost ghost changed the title [AWS] Migrate NATGateway visualizations to lenses Mar 1, 2023
@ghost
ghost force-pushed the migrate_aws-natgateway_vis-to-lens branch from 680beda to 4e2e5ad Compare March 1, 2023 22:40
@elasticmachine

elasticmachine commented Mar 1, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-07T22:21:18.613+0000

  • Duration: 54 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Mar 1, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.125
Classes 93.75% (15/16) 👎 -3.125
Methods 85.921% (238/277) 👎 -3.121
Lines 85.925% (7387/8597) 👎 -2.31
Conditionals 100.0% (0/0) 💚
@ghost
ghost force-pushed the migrate_aws-natgateway_vis-to-lens branch from 4e2e5ad to 7471846 Compare March 8, 2023 13:02
@ghost
ghost marked this pull request as ready for review March 21, 2023 16:23
@ghost
ghost requested review from a team as code owners March 21, 2023 16:23
@ghost ghost added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
drewdaemon
drewdaemon reviewed Apr 5, 2023
View reviewed changes

@drewdaemon drewdaemon left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One request: let's avoid using the Legacy Metric in favor of the Metric chart.
@botelastic

botelastic Bot commented May 5, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!
@botelastic botelastic Bot added the Stalled label May 5, 2023
@botelastic botelastic Bot removed the Stalled label May 14, 2023
@ghost

ghost commented May 14, 2023

Copy link
Copy Markdown
Author

I replaced legacy metrics charts with metrics charts.

Here's how it looks now:

natgateway_metrics
@drewdaemon

drewdaemon commented May 18, 2023

Copy link
Copy Markdown
Contributor

From meeting

  • can try stacking all three metrics in a single column
  • increase width and height of Action Connection Count bar chart
@ghost ghost self-assigned this May 22, 2023
@ghost

ghost commented May 29, 2023

Copy link
Copy Markdown
Author

@drewdaemon what do you think about the width of the metric charts?

natgateway_new_layout
@drewdaemon

drewdaemon commented May 30, 2023

Copy link
Copy Markdown
Contributor

Looks good to me! @gvnmagni WDYT ^^
@gvnmagni

gvnmagni commented May 31, 2023

Copy link
Copy Markdown

Absolutely! 👍
@ghost
ghost merged commit ba9f302 into elastic:main Jun 7, 2023
@elasticmachine

elasticmachine commented Jun 7, 2023

Copy link
Copy Markdown

Package aws - 1.41.0 containing this change is available at https://epr.elastic.co/search?package=aws
sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
Gabriel Pop @sodhikirti07
[AWS] Migrate NATGateway metrics visualizations to lenses (#5426)
531edc6 
* add lenses and input control groups

* bump package version

* replace legacy with metric charts

* fix layout
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Gabriel Pop
[AWS] Migrate NATGateway metrics visualizations to lenses (elastic#5426)
97213e9 
* add lenses and input control groups

* bump package version

* replace legacy with metric charts

* fix layout
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

5 participants

@elasticmachine @drewdaemon @gvnmagni @zmoog @mrg-elastic