Skip to content

okta: allow configuration of http keep-alives - #5487

Merged
efd6 merged 1 commit into
elastic:mainfrom
efd6:4844-okta
Mar 9, 2023
Merged

okta: allow configuration of http keep-alives#5487
efd6 merged 1 commit into
elastic:mainfrom
efd6:4844-okta

Conversation

@efd6

@efd6 efd6 commented Mar 9, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Allows configuration of HTTP keep-alives. The default used departs from the current behaviour (disabled) to ensure the best experience for most cases by allowing connection reuse, but can be reverted to the old behaviour if needed.

It is an advanced configuation option since it's expected to not be needed in the vast majority of cases.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Mar 9, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-09T01:21:14.719+0000

  • Duration: 14 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Mar 9, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (19/19) 💚 9.091
Lines 87.864% (543/618) 👎 -4.929
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review March 9, 2023 01:23
@efd6
efd6 requested a review from a team as a code owner March 9, 2023 01:23
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6
efd6 merged commit 581d4d4 into elastic:main Mar 9, 2023
@elasticmachine

Copy link
Copy Markdown

Package okta - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=okta

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6
efd6 deleted the 4844-okta branch February 5, 2025 22:06
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:okta Okta

3 participants