Skip to content

Update: Add forcer_merge to the node stats metric - #5508

Merged
klacabane merged 6 commits into
elastic:mainfrom
redcinelli:add_forcemerge_threadpools
Mar 31, 2023
Merged

Update: Add forcer_merge to the node stats metric#5508
klacabane merged 6 commits into
elastic:mainfrom
redcinelli:add_forcemerge_threadpools

Conversation

@redcinelli

@redcinelli redcinelli commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This Pr is linked to another one made in elasticsearch.node_stats in the beat repository.

I am adding the number of force_merge queuing and rejected to be picked up by metricbeat.

As pointed out by @klacabane I need to bring those changes here too.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • This PR on elasticsearch repo needs to also be accepted

How to test this PR locally

Related issues

Screenshots
@elasticmachine

elasticmachine commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-31T15:24:03.118+0000

  • Duration: 31 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 59
Skipped 0
Total 59

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112) 👎 -10.722
Lines 91.98% (562/611) 👎 -3.826
Conditionals 100.0% (0/0) 💚
@redcinelli redcinelli added the enhancement New feature or request label Mar 13, 2023
@redcinelli
redcinelli marked this pull request as ready for review March 14, 2023 10:13
@redcinelli
redcinelli requested a review from a team as a code owner March 14, 2023 10:13
@redcinelli redcinelli mentioned this pull request Mar 14, 2023
Merged
6 tasks
@miltonhultgren miltonhultgren added Integration:elasticsearch Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services labels Mar 16, 2023
klacabane
klacabane approved these changes Mar 31, 2023
View reviewed changes

@klacabane klacabane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the change!
@klacabane
klacabane merged commit b8e4103 into elastic:main Mar 31, 2023
@elasticmachine

elasticmachine commented Mar 31, 2023

Copy link
Copy Markdown

Package elasticsearch - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=elasticsearch
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@redcinelli @klacabane
Update: Add forcer_merge to the node stats metric (elastic#5508)
00a72ec 
* Update: Add forcer_merge to the node stats metric

* Update: read was out of sync

* Update: Add entry to changlogs

* Fix: manifest file version

---------

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:elasticsearch Elasticsearch Team:Infra Monitoring UI - DEPRECATED Label for the Infrastructure Monitoring UI team. - DEPRECATED - Use Team:obs-ux-infra_services

4 participants

@redcinelli @elasticmachine @klacabane @miltonhultgren