Skip to content

Update metrictype for fields of performance data stream. - #5532

Merged
ritalwar merged 3 commits into
elastic:mainfrom
ritalwar:mssql_tsdb_metrictype_performance_5278
Mar 20, 2023
Merged

Update metrictype for fields of performance data stream.#5532
ritalwar merged 3 commits into
elastic:mainfrom
ritalwar:mssql_tsdb_metrictype_performance_5278

Conversation

@ritalwar

@ritalwar ritalwar commented Mar 14, 2023

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR updates the metric_type meta data for fields of performance data stream of mssql

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Add the microsoft_sqlserver integration.
In integration's overview page, metric type could be confirmed.
Enable performance data stream and you should see metrics successfully.

Related issues

@ritalwar ritalwar mentioned this pull request Mar 14, 2023
11 tasks
@elasticmachine

elasticmachine commented Mar 14, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T12:32:16.058+0000

  • Duration: 16 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Mar 14, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.333% (28/30) 👍
Lines 100.0% (1238/1238) 💚
Conditionals 100.0% (0/0) 💚
@ritalwar
ritalwar marked this pull request as ready for review March 15, 2023 04:29
@ritalwar
ritalwar requested a review from a team as a code owner March 15, 2023 04:29

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar
ritalwar merged commit 7e4689c into elastic:main Mar 20, 2023
@elasticmachine

Copy link
Copy Markdown

Package microsoft_sqlserver - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Update metrictype for fields of performance data stream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants