Skip to content

[ GCP ] Fix convert processor in Audit Pipeline - #5597

Merged
efd6 merged 2 commits into
elastic:mainfrom
leandrojmp:fix_gcp_audit_ip_convert
Mar 20, 2023
Merged

[ GCP ] Fix convert processor in Audit Pipeline#5597
efd6 merged 2 commits into
elastic:mainfrom
leandrojmp:fix_gcp_audit_ip_convert

Conversation

@leandrojmp

@leandrojmp leandrojmp commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

The Audit ingest pipeline has a convert processor that was breaking because the value of the field json.protoPayload.requestMetadata.callerIp is a string that was not being considered in the conditional.

This PR adds a new check in the conditional of the convert processor.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@leandrojmp
leandrojmp requested review from a team as code owners March 20, 2023 21:06
@elasticmachine

elasticmachine commented Mar 20, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-20T23:34:19.972+0000

  • Duration: 18 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@leandrojmp

leandrojmp commented Mar 20, 2023

Copy link
Copy Markdown
Contributor Author

Hello @efd6 , can you add the correct labels in this PR? Thanks!
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:gcp Google Cloud Platform labels Mar 20, 2023
@elasticmachine

elasticmachine commented Mar 20, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6

efd6 commented Mar 20, 2023

Copy link
Copy Markdown
Contributor

/test
@elasticmachine

elasticmachine commented Mar 20, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (6/6) 💚
Files 100.0% (6/6) 💚
Classes 100.0% (6/6) 💚
Methods 90.291% (93/103) 👍 23.281
Lines 96.0% (1464/1525) 👎 -2.797
Conditionals 100.0% (0/0) 💚
efd6
efd6 approved these changes Mar 20, 2023
View reviewed changes

@efd6 efd6 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6
efd6 merged commit 8a6b1af into elastic:main Mar 20, 2023
@elasticmachine

elasticmachine commented Mar 21, 2023

Copy link
Copy Markdown

Package gcp - 2.17.2 containing this change is available at https://epr.elastic.co/search?package=gcp
@leandrojmp
leandrojmp deleted the fix_gcp_audit_ip_convert branch May 22, 2023 19:04
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@leandrojmp
[ GCP ] Fix IP convert processor in Audit Pipeline (elastic#5597)
1d199af 
* add conditional for "private" in convert processor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:gcp Google Cloud Platform

3 participants

@leandrojmp @elasticmachine @efd6