Skip to content

[Okta] Add username from email - #5603

Merged
bhapas merged 3 commits into
elastic:mainfrom
bhapas:okta-fix
Mar 21, 2023
Merged

[Okta] Add username from email#5603
bhapas merged 3 commits into
elastic:mainfrom
bhapas:okta-fix

Conversation

@bhapas

@bhapas bhapas commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR extracts the username from email and adds it to the document.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack down && elastic-package build && elastic-package stack up -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test

Related issues
@bhapas bhapas self-assigned this Mar 21, 2023
@bhapas
bhapas marked this pull request as ready for review March 21, 2023 09:18
@bhapas
bhapas requested a review from a team as a code owner March 21, 2023 09:18
@elasticmachine

elasticmachine commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T09:48:08.103+0000

  • Duration: 14 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@bhapas

bhapas commented Mar 21, 2023

Copy link
Copy Markdown
Contributor Author

/test
@bhapas bhapas changed the title Add username from email Mar 21, 2023
@marc-gr

marc-gr commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

LGTM, just a note that might be nice if we add the username to the related.user list, also
@elasticmachine

elasticmachine commented Mar 21, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) ��
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (19/19) 💚
Lines 88.263% (564/639) 👎 -4.088
Conditionals 100.0% (0/0) 💚
@bhapas
bhapas merged commit 99bfd80 into elastic:main Mar 21, 2023
@bhapas
bhapas deleted the okta-fix branch March 21, 2023 10:04
@elasticmachine

elasticmachine commented Mar 21, 2023

Copy link
Copy Markdown

Package okta - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=okta
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@bhapas
[Okta] Add username from email (elastic#5603)
3250d96 
* Add username from email

* Add to related-user

* Fix build comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@bhapas @elasticmachine @marc-gr