Skip to content

[AWS] Migrate SNS dashboard to lenses - #5642

Merged
4 commits merged into
mainfrom
unknown repository
May 26, 2023
Merged

[AWS] Migrate SNS dashboard to lenses#5642
4 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Mar 22, 2023

Copy link
Copy Markdown

What does this PR do?

Migrates visualizations to lenses and adds input control groups.

Before:
sns_before

After:
sns_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ghost ghost added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Mar 22, 2023
@elasticmachine

elasticmachine commented Mar 22, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-26T11:54:52.226+0000

  • Duration: 51 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Mar 22, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16)
Classes 93.75% (15/16)
Methods 86.131% (236/274)
Lines 85.925% (7387/8597)
Conditionals 100.0% (0/0) 💚
@ghost
ghost marked this pull request as ready for review March 22, 2023 19:48
@ghost
ghost requested review from a team as code owners March 22, 2023 19:48

@drewdaemon drewdaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic

botelastic Bot commented May 5, 2023

Copy link
Copy Markdown

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label May 5, 2023
@botelastic botelastic Bot removed the Stalled label May 14, 2023
@ghost ghost self-assigned this May 22, 2023
@ghost
ghost merged commit 257219b into elastic:main May 26, 2023
@elasticmachine

Copy link
Copy Markdown

Package aws - 1.37.1 containing this change is available at https://epr.elastic.co/search?package=aws

@rameshelastic rameshelastic mentioned this pull request May 29, 2023
15 tasks
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* add lenses and input control group

* bump package version
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants