Skip to content

Add ssl support to elasticsearch ingest pipeline datastream - #5939

Merged
klacabane merged 6 commits into
elastic:mainfrom
JulienOrain:patch-1
Apr 25, 2023
Merged

Add ssl support to elasticsearch ingest pipeline datastream#5939
klacabane merged 6 commits into
elastic:mainfrom
JulienOrain:patch-1

Conversation

@JulienOrain

Copy link
Copy Markdown
Contributor

What does this PR do?

Add ssl support to elasticsearch ingest_pipeline data stream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

NA

How to test this PR locally

NA

Related issues

Screenshots

@JulienOrain
JulienOrain requested a review from a team as a code owner April 20, 2023 13:27
@elasticmachine

elasticmachine commented Apr 20, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-25T10:46:07.606+0000

  • Duration: 31 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 60
Skipped 0
Total 60

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@klacabane klacabane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JulienOrain, thank you for the change! I see that other parameters added in #5353 are also missing from the ingest_pipeline data stream. I've made a suggestion to include them.

We also need to bump the version in the manifest.yml

@klacabane

Copy link
Copy Markdown
Contributor

/test

JulienOrain and others added 2 commits April 24, 2023 22:25
…m/stream.yml.hbs

Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
@JulienOrain

Copy link
Copy Markdown
Contributor Author

Hi @klacabane !
Thanks a lot for the suggestion and the manifest.yml info !
Hope that's better ;-)

@klacabane

Copy link
Copy Markdown
Contributor

/test

@elasticmachine

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 87.5% (98/112)
Lines 91.98% (562/611)
Conditionals 100.0% (0/0) 💚
Comment thread packages/elasticsearch/changelog.yml Outdated
Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
@klacabane

Copy link
Copy Markdown
Contributor

/test

@klacabane klacabane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klacabane
klacabane merged commit 6463a81 into elastic:main Apr 25, 2023
@elasticmachine

Copy link
Copy Markdown

Package elasticsearch - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=elasticsearch

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…5939)

* add ssl support to elasticsearch ingest_pipeline

* Update changelog.yml

* Update changelog.yml

* Update packages/elasticsearch/data_stream/ingest_pipeline/agent/stream/stream.yml.hbs

Co-authored-by: Kevin Lacabane <klacabane@gmail.com>

* Update manifest.yml

* Update packages/elasticsearch/changelog.yml

Co-authored-by: Kevin Lacabane <klacabane@gmail.com>

---------

Co-authored-by: Kevin Lacabane <klacabane@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants