Skip to content

[iptables,journald] Re-enable system tests for journald inputs - #5984

Merged
andrewkroh merged 3 commits into
elastic:mainfrom
andrewkroh:bugfix/enable-journald-tests
Apr 27, 2023
Merged

[iptables,journald] Re-enable system tests for journald inputs#5984
andrewkroh merged 3 commits into
elastic:mainfrom
andrewkroh:bugfix/enable-journald-tests

Conversation

@andrewkroh

@andrewkroh andrewkroh commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

System tests for the journald input have been disabled to a segfault. This uses a workaround to avoid that segfault so we can continue testing.

Closes #2602
Blocked by: elastic/elastic-package#1236

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine

elasticmachine commented Apr 24, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-26T18:54:44.272+0000

  • Duration: 15 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Apr 25, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 3.043
Classes 100.0% (1/1) 💚 3.043
Methods 100.0% (16/16) 💚 8.244
Lines 92.453% (294/318) 👍 0.375
Conditionals 100.0% (0/0) 💚
system tests for the journald input have been disabled to a segfault. This uses a workaround
to avoid that segfault so we can continue testing.

Closes #2602
Relates elastic/elastic-package#1236
ECS added numerous log.syslog fields that should be used by journald
instead of syslog.*.

And because this is an input package this needs to be done without
an Ingest Pipeline so that users with custom pipelines can benefit.
ECS added numerous log.syslog fields that should be used
by the journald input instead of syslog.*. So rename the
fields in the ingest pipeline.

Bump stack version to get journald input fixes.
@andrewkroh
andrewkroh marked this pull request as ready for review April 26, 2023 18:55
@andrewkroh
andrewkroh requested review from a team as code owners April 26, 2023 18:55
@elasticmachine

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@andrewkroh
andrewkroh merged commit e55da04 into elastic:main Apr 27, 2023
@elasticmachine

Copy link
Copy Markdown

Package iptables - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=iptables

@elasticmachine

Copy link
Copy Markdown

Package journald - 1.0.1 containing this change is available at https://epr.elastic.co/search?package=journald

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…ic#5984)

system tests for the journald input have been disabled to a segfault. This uses a workaround
to avoid that segfault so we can continue testing.

While performing that testing I discovered that neither iptables nor journald were
aligned with the current ECS definition of the log.syslog.* fields. ECS added
numerous log.syslog fields that should be used by journald/iptables
instead of syslog.*.

And because journald is an input package this needs to be done without
an Ingest Pipeline so that users with custom pipelines can benefit.

Bump stack version for the iptables integration to get journald input fixes.

Closes elastic#2602
Relates elastic/elastic-package#1236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants