Skip to content

okta: retain targeting information - #6010

Merged
efd6 merged 3 commits into
elastic:mainfrom
efd6:5982-okta
May 3, 2023
Merged

okta: retain targeting information#6010
efd6 merged 3 commits into
elastic:mainfrom
efd6:5982-okta

Conversation

@efd6

@efd6 efd6 commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Retains the structure of targeting information under okta. and properly fills out user.target.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Apr 27, 2023
@elasticmachine

elasticmachine commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-27T03:34:46.202+0000

  • Duration: 15 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6
make type matching precise
1376db2 
Previously, if the group appeared before the user, it would be chosen as
the user array element since the type is "UserGroup".
@elasticmachine

elasticmachine commented Apr 27, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.016
Classes 100.0% (1/1) 💚 2.016
Methods 100.0% (19/19) 💚 5.609
Lines 91.948% (571/621) 👎 -1.314
Conditionals 100.0% (0/0) 💚
@efd6
efd6 marked this pull request as ready for review April 27, 2023 02:24
@efd6
efd6 requested a review from a team as a code owner April 27, 2023 02:24
@elasticmachine

elasticmachine commented Apr 27, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6
efd6 requested a review from SpencerLN April 27, 2023 02:24
SpencerLN
SpencerLN reviewed Apr 27, 2023
View reviewed changes
Comment thread packages/okta/data_stream/system/elasticsearch/ingest_pipeline/default.yml
@efd6
efd6 merged commit 3a53ce0 into elastic:main May 3, 2023
@elasticmachine

elasticmachine commented May 3, 2023

Copy link
Copy Markdown

Package okta - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=okta
@efd6 efd6 mentioned this pull request May 3, 2023
Merged
4 tasks
@efd6
efd6 deleted the 5982-okta branch February 5, 2025 22:11
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@efd6
okta: retain targeting information (elastic#6010)
4b38d91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:okta Okta

4 participants

@efd6 @elasticmachine @SpencerLN @P1llus