Skip to content

Added metric_type fields for metrics datastream. - #6042

Merged
ritalwar merged 5 commits into
elastic:mainfrom
ritalwar:mongodb_tsdb_metrictype_metrics_5281
May 22, 2023
Merged

Added metric_type fields for metrics datastream.#6042
ritalwar merged 5 commits into
elastic:mainfrom
ritalwar:mongodb_tsdb_metrictype_metrics_5281

Conversation

@ritalwar

@ritalwar ritalwar commented May 1, 2023

Copy link
Copy Markdown
Contributor
  • Enhancement

What does this PR do?

This PR adds metric_type for the fields of metrics data stream of mongoldb.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar
ritalwar marked this pull request as ready for review May 1, 2023 09:24
@ritalwar
ritalwar requested a review from a team as a code owner May 1, 2023 09:24
@ritalwar ritalwar mentioned this pull request May 1, 2023
26 tasks
@elasticmachine

elasticmachine commented May 1, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-20T17:50:31.284+0000

  • Duration: 18 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 1, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.022
Classes 100.0% (3/3) 💚 3.022
Methods 96.97% (32/33) 👍 5.25
Lines 68.217% (88/129) 👎 -23.782
Conditionals 100.0% (0/0) 💚
@elasticmachine

elasticmachine commented May 1, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 2.866
Classes 100.0% (3/3) 💚 2.866
Methods 96.97% (32/33) 👍 4.421
Lines 68.217% (88/129) 👎 -23.764
Conditionals 100.0% (0/0) 💚

@agithomas agithomas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar

ritalwar commented May 5, 2023

Copy link
Copy Markdown
Contributor Author

/test

@ritalwar ritalwar mentioned this pull request May 19, 2023
16 tasks
@ritalwar
ritalwar merged commit 02982e0 into elastic:main May 22, 2023
@elasticmachine

Copy link
Copy Markdown

Package mongodb - 1.9.5 containing this change is available at https://epr.elastic.co/search?package=mongodb

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Added metric_type fields for metrics datastream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants