Skip to content

[Kubernetes][Container] Add container name as dimension - #6108

Merged
constanca-m merged 3 commits into
elastic:mainfrom
constanca-m:kubernetes-add-dimension
May 5, 2023
Merged

[Kubernetes][Container] Add container name as dimension#6108
constanca-m merged 3 commits into
elastic:mainfrom
constanca-m:kubernetes-add-dimension

Conversation

@constanca-m

Copy link
Copy Markdown
Contributor

What does this PR do?

The dimensions set for the container data stream are not enough, since a pod can have multiple containers. In that case, without setting the container name (unique per pod) as dimension, there would be no way to distinguish between documents from different containers in the same pod.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Relates to #4618.

Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@constanca-m
constanca-m requested a review from gizas May 5, 2023 14:45
@constanca-m constanca-m self-assigned this May 5, 2023
@constanca-m
constanca-m requested review from a team as code owners May 5, 2023 14:45
@constanca-m
constanca-m requested a review from devamanv May 5, 2023 14:45
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
@elasticmachine

elasticmachine commented May 5, 2023

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-05T14:47:51.157+0000

  • Duration: 28 min 27 sec

Test stats 🧪

Test Results
Failed 0
Passed 92
Skipped 0
Total 92

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented May 5, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 96.154% (75/78) 👎 -3.846
Lines 100.0% (0/0) 💚 1.955
Conditionals 100.0% (0/0) 💚
@constanca-m
constanca-m merged commit 06214f9 into elastic:main May 5, 2023
@constanca-m
constanca-m deleted the kubernetes-add-dimension branch May 5, 2023 15:36
@elasticmachine

Copy link
Copy Markdown

Package kubernetes - 1.36.0 containing this change is available at https://epr.elastic.co/search?package=kubernetes

@tetianakravchenko

tetianakravchenko commented May 10, 2023

Copy link
Copy Markdown
Contributor

@constanca-m why was this field introduced? shouldn't it be covered by the container.id field, that is set as dimension already?

@gizas

gizas commented May 10, 2023

Copy link
Copy Markdown
Contributor

I had missed that @tetianakravchenko ! I thought we had only pod.uid which was not enough that is why this PR.

Indeed I think we can cancel this

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
* Add dimension container.name


Signed-off-by: constanca-m <constanca.manteigas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants