Skip to content

[AWS] Fix typo in field name causing erroneous timestamp detection on s3access - #6213

Merged
zmoog merged 4 commits into
elastic:mainfrom
zmoog:zmoog/s3access-fix-typo
May 16, 2023
Merged

[AWS] Fix typo in field name causing erroneous timestamp detection on s3access#6213
zmoog merged 4 commits into
elastic:mainfrom
zmoog:zmoog/s3access-fix-typo

Conversation

@zmoog

@zmoog zmoog commented May 15, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Fix a small typo in a field name.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@zmoog zmoog added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label May 15, 2023
@zmoog zmoog self-assigned this May 15, 2023
@zmoog
zmoog marked this pull request as ready for review May 15, 2023 17:36
@zmoog
zmoog requested a review from a team as a code owner May 15, 2023 17:36
@elasticmachine

elasticmachine commented May 15, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-16T08:04:12.669+0000

  • Duration: 53 min 51 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine

elasticmachine commented May 15, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -13.869
Lines 85.925% (7387/8597) 👎 -7.896
Conditionals 100.0% (0/0) 💚
@zmoog
Add missing @timestamp field in expected results
9e6ea19 
I guess this value wasn't generated due to the typo
@zmoog
zmoog merged commit 4708c6f into elastic:main May 16, 2023
@zmoog
zmoog deleted the zmoog/s3access-fix-typo branch May 16, 2023 08:58
@elasticmachine

elasticmachine commented May 16, 2023

Copy link
Copy Markdown

Package aws - 1.35.1 containing this change is available at https://epr.elastic.co/search?package=aws
@elasticmachine

elasticmachine commented May 23, 2023

Copy link
Copy Markdown

Package aws - 1.36.8 containing this change is available at https://epr.elastic.co/search?package=aws
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@zmoog @tommyers-elastic
[AWS] Fix typo in field name causing erroneous timestamp detection on…
bf0b4b1 
… s3access (elastic#6213)

* Fix typo in field name causing erroneous timestamp detection

* Add missing `@timestamp` field in expected results

I guess this value wasn't generated due to the typo.

---------

Co-authored-by: Tom Myers <106530686+tommyers-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants

@zmoog @elasticmachine @tommyers-elastic @andrewkroh